Add BackdropComponent prop to resolve issue with transitionDuration prop on MUI v4 #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration prop on MUI v4
|
Thank you! 👏 If it really actually works fine with both versions, I think we should update the peer dependency to reflect that and disable the warning when using this with MUI v4. |
leMaik
changed the title
|
Yeah, the change made works in MUI v3 & v4, but I cannot confirm that every feature and option of your app will be supported by v4 to be honest :) Although everything does appear to work, and removes the only error message I had in the console on a project that uses MUI v4. |
|
@OliverJEvans I think that's sufficient. I'll change the peer dependency to Again, thanks for this nice first contribution. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Material UI v3 the modal uses the Backdrop component which supports transitionDuration.
In Material UI v4 the modal uses a 'SimpleBackdrop' component with limited prop support.
This change forces the Modal to use the Backdrop component. This will make no visual or behavioural difference in MUI v3 and enables support for transitionDuration in MUI v4.
Fixes #66