Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings for deprecated APIs #47

Merged
merged 2 commits into from
Dec 22, 2018
Merged

Conversation

skirunman
Copy link
Contributor

Fix warnings for deprecated use of Material-UI fab and raised button variants and with new Fab component and contained button variant. Fixes #46
See https://material-ui.com/api/button/

Fix warnings for deprecated use of Material-UI `fab` and `raised` button variants and with new `Fab` component and `contained` button variant. Fixes TeamWertarbyte#46
See https://material-ui.com/api/button/
@leMaik
Copy link
Member

leMaik commented Dec 18, 2018

Thank you. 👍 As said in #46 I'll wait for v4 to be released before merging this PR.

@skirunman
Copy link
Contributor Author

skirunman commented Dec 18, 2018

Only problem with waiting is anyone in production, like us, is going to have those warnings show up in their user's browser console. We are definitely going to get some support calls on that. Also, my guess is that most, if not all, users of this component are tracking the latest releases of Material-UI as there are many bug fixes and enhancements.

Would it not be possible to simply do a 3.0.0 release with these changes now with peer dependencies on "@material-ui/core": "^3.6.0" and "@material-ui/icons": "^3.0.1" and then do a 4.0.0 release when Material-UI 4 comes out some time next year? I really appreciate your consideration as this is an issue for us. Thanks!

@leMaik
Copy link
Member

leMaik commented Dec 18, 2018

@skirunman Good idea, I'll release it soon.

Offtopic: The warnings show up in your user's browser consoles? 😱 You should fix your bundler settings in order to ship production versions of prop-types that don't print warnings in production environments. They are just warnings, after all.

@skirunman
Copy link
Contributor Author

@leMaik Thanks!

src/AutoRotatingCarousel.js Outdated Show resolved Hide resolved
@leMaik leMaik merged commit 7a41bea into TeamWertarbyte:master Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants