Add dotColor and updated dots #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leMaik
requested changes
Nov 30, 2017
| @@ -195,6 +195,7 @@ export default class AutoRotatingCarousel extends Component { | |||
| index={modulo(this.state.slideIndex, this.props.children.length)} | |||
| style={landscape ? style.dotsLandscape : style.dots} | |||
| onDotClick={this.handleChange} | |||
| dotColor={this.props.dotColor} | |||
There was a problem hiding this comment.
This prop should be destructured above.
There was a problem hiding this comment.
Can you elaborate on what you mean by that? I'm not seeing any other destructuring of this.props.
|
@TeaSeaLancs Thank you! 👍 |
leMaik
approved these changes
Nov 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the version of material-ui-dots and adds a dotColor property which passes through to the Dots component.