[YouTube] Fix extraction of more complex nsig functions

[Theta-Dev]

I fixed the "Could not get any stream" error that occurred after a YouTube update on 12.08.2022.

The issue was that the more complex nsig decryption function now includes curly braces inside strings, which the findNextParenthesis function could not handle. This resulted in the extraction of broken JavaScript and an interpreter error.

Fixes TeamNewPipe/NewPipe#8760.

This PR also catches really this time throttling errors, to really prevent extraction issues when the throttling parameter could not be decrypted.

Test APK: app-debug.zip

• I carefully read the contribution guidelines and agree to them.
• I have tested the API against NewPipe.

[mdb571]

So fast \o/ Thanks for the fix :)

[AudricV]

Thank you very much!

A few code style issues are present, but if you tested yourself and it works, I think that's fine :)

Could you also apply TeamNewPipe/NewPipe#8760 (comment) if possible, so #786 is finally doing its job? Thank you in advance!

Edit: I will do all the changes myself

[Sk44rt]

So we'll just wait for merging and making new release

[AudricV]

Yes, but I'd like to fix TeamNewPipe/NewPipe#8713 on the fly, by merging #890 once I updated mocks, as it would be great if we don't have to make a second hotfix release :)

[Theta-Dev]

Here is a test build of NewPipe if you want to try the fix:
app-debug.zip

[FireMasterK]

LGTM!

[FireMasterK]

The grave character (`) should also probably be included since they can be used to create multi-line strings.

[AudricV]

Thank you again for your contribution, @Theta-Dev!

[jirafey]

I want to thank you from the bottom of my heart 🥇

[Gitoffthelawn]

In TeamNewPipe/NewPipe#8760 (comment), @AudricV indicates:

What seem to happen is that the function is not extracted fully, because of new line breaks.

We have a code to prevent this issue, but it doesn't catch any exception, but only ParsingExceptions. If we make YoutubeThrottlingDecrypter.apply(String, String) throwing any Exception instead of a ParsingException and that we catch this exception, the anti-break code works.

If I'm reading this correctly, it sounds like the exception handler wasn't working because it was only detecting (and thus handling) ParsingExceptions instead of all exceptions. It appears the above recommendation may a good one because it will handle possible situations in the future that are similar to this issue.

In addition to the recommendation made in the above quote, it seems logical to also handle the new upstream string format so that no exception is generated (which will therefore handle throttling as intended within NewPipe). Has this already been done, or is that a separate task that needs to be completed?

[AudricV]

I already included this in 5b54834 😉

[Gitoffthelawn]

@AudricV wrote:

I already included this in 5b54834 wink

Was your response intended for me? If so, thank you! 👍🏾