Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SoundCloud] Fix certain playlists showing as empty #1049

Closed

Conversation

petlyh
Copy link
Contributor

@petlyh petlyh commented Apr 13, 2023

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.
    No NewPipe changes required.

For certain SoundCloud playlists, the initial playlist data does not include the full track info for any of the tracks. Because of this, no items get collected in getIntialPage and NewPipe shows the playlist as empty.

This change makes it so that getPage is used in initial extraction in those cases to prevent getInitialPage from returning no items.

I have tested that other playlists still work, including actually empty ones.

Fixes TeamNewPipe/NewPipe#10012

Before After

@TobiGr TobiGr added bug soundcloud service, https://soundcloud.com/ labels Apr 13, 2023
@Stypox
Copy link
Member

Stypox commented Apr 13, 2023

This should be changed on NewPipe's side. I just tested and the following commit from TeamNewPipe/NewPipe#10018 fixes the issue: TeamNewPipe/NewPipe@e236d37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug soundcloud service, https://soundcloud.com/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SoundCloud large playlist can’t load
3 participants