Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update desugar_jdk_libs to 2.0.0. #9686

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

Isira-Seneviratne
Copy link
Member

@Isira-Seneviratne Isira-Seneviratne commented Jan 15, 2023

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Now that Android Studio Electric Eel has finally been released, we can update AGP to 7.4.x (previously max version was 7.3.x). This also allows upgrading desugaring to Desugaring 2.0.0, which requires Java 11 at build time.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@sonarcloud
Copy link

sonarcloud bot commented Jan 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Stypox
Copy link
Member

Stypox commented Jan 15, 2023

I added a proper description to the PR. Also, do you know which improvements desugaring 2.0.0 has over 1.2.x, except for splitting modules and using JDK 11? Does it desugar more things now?

@Isira-Seneviratne
Copy link
Member Author

Isira-Seneviratne commented Jan 16, 2023

I added a proper description to the PR.

Sorry about that.

Also, do you know which improvements desugaring 2.0.0 has over 1.2.x, except for splitting modules and using JDK 11? Does it desugar more things now?

Yeah, the java.nio packages are desugared, including StandardCharsets for API levels below 19 and the java.nio.file package, which was introduced in API 26 (the desugar_jdk_libs_nio library is required for that).

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on APIs 22 and 33 and it seems to work normally. Thanks!

@Stypox Stypox merged commit aa41fec into TeamNewPipe:dev Jan 16, 2023
@Stypox Stypox mentioned this pull request Jan 22, 2023
3 tasks
@Isira-Seneviratne Isira-Seneviratne deleted the Update_desugar branch January 30, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants