Allow the user to permanently set a thumbnail #9523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for another failed test. All of them worked locally, but i forgot to add the unversioned file "6.json". I will fix this asap. |
|
Should I run it now? |
|
Yes, that would be great. I have really pushed everything now and tested it again locally. Everything should work now. |
Stypox
requested changes
Jan 1, 2023
app/src/main/java/org/schabi/newpipe/local/bookmark/BookmarkFragment.java
Outdated
Show resolved
Hide resolved
Stypox
reviewed
Jan 1, 2023
app/src/main/java/org/schabi/newpipe/local/bookmark/BookmarkFragment.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
Stypox
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Rename,Delete,Unset Thumbnail.RenameandDeleteopen the respective dialog.Unset Thumbnailis only enabled if the thumbnail has been permanently set. If you press this option, the permanent playlist thumbnail is unset and a new one gets chosen automatically (first video in the playlist or a default thumbnail if there is no video in the playlist).Before/After Screenshots/Screen Record
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence