Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential cast exception in comments text #9065

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

devlearner
Copy link
Contributor

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Fixes potential exception when casting to Spannable in CommentTextOnTouchListener

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

when casting to `Spannable` in `CommentTextOnTouchListener`
@devlearner devlearner marked this pull request as ready for review October 4, 2022 09:42
@AudricV AudricV added the bug Issue is related to a bug label Oct 4, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks reasonable. I am not able to reproduce the original crash on the emulator. The users who reported the crash say that this PR fixes it.

Thank you.

@TobiGr TobiGr merged commit 7fca0e0 into TeamNewPipe:dev Oct 10, 2022
@tsiflimagas tsiflimagas mentioned this pull request Oct 27, 2022
6 tasks
This was referenced Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when touching on (some) comment
3 participants