Reduce View.kt size. #8708

Isira-Seneviratne · 2022-07-30T02:28:05Z

What is it?

Bugfix (user facing)
Feature (user facing)
Codebase improvement (dev facing)
Meta improvement to the project (dev facing)

Description of the changes in your PR

Use nested functions in View.kt.
Create reusable class which overrides AnimatorListenerAdapter.

Fixes the following issue(s)

Fixes #

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

I read the contribution guidelines.

Stypox

Thanks, looks almost good

Stypox · 2022-08-03T20:40:45Z

app/src/main/java/org/schabi/newpipe/ktx/View.kt

+private class RunnableExecutorAdapter(
+    private val view: View,
+    private val execOnEnd: Runnable?,
+    private val shouldHideView: Boolean
+) : AnimatorListenerAdapter() {
+    override fun onAnimationEnd(animation: Animator) {
+        if (shouldHideView) {
+            view.isGone = true
+        }
+        execOnEnd?.run()
+    }
+}


I'd create two classes, one for when shouldHideView is true, one for when it's false, in order to avoid that runtime check (maybe the second can extend the first, but idk). The names for the two classes should be imo: HideAndExecOnEndListener and ExecOnEndListener. RunnableExecutorAdapter is not so meaningful.