Use smoother bitmap downscaling for thumbnails.

[Isira-Seneviratne]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Use BitmapCompat.createScaledBitmap() for smoother thumbnail downscaling.

Before/After Screenshots/Screen Record

Fixes the following issue(s)

• Fixes #

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

• I read the contribution guidelines.

[Isira-Seneviratne]

When checking the change in PicassoHelper on my Galaxy Tab A6 (Android 8.1), I found that the result bitmap was mutable while the source was immutable, so I removed the bug fix for the issue mentioned. I'll restore it if needed.

[Stypox]

Could you provide screenshots for comparison? Does the benefits exceed the cost of possibly having bugs or crashes?

[Isira-Seneviratne]

Could you provide screenshots for comparison? Does the benefits exceed the cost of possibly having bugs or crashes?

The documentation mentions that a mutable bitmap is returned if the original was immutable.

Edit: If the source bitmap was not returned, and the source is returned if the new dimensions were the same as the original.

[Stypox]

@gulachev @arielshulman could you test if this PR still works fine, or if it reintroduces #4638? Assuming you still have the same phone.

[Isira-Seneviratne]

@Stypox I added a mutable copy operation if the resulting bitmap was immutable (this only happens if the source bitmap was returned and it was immutable).

@mhmdanas Can you update the labels?

[arielshulman]

@gulachev @arielshulman could you test if this PR still works fine, or if it reintroduces #4638? Assuming you still have the same phone.

Hey, brought that phone to my boy...
I've tested the apk from CI and it worked great with those specific bitmaps which crashed the phone when it displayed on notification bar.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[TobiGr]

lgtm

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[Stypox]

Something strange happened. Anyway, this is approved and merged in #9479, thanks @Isira-Seneviratne :-)