Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AppCompat to 1.4.2. #8667

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

Isira-Seneviratne
Copy link
Member

@Isira-Seneviratne Isira-Seneviratne commented Jul 21, 2022

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Update AppCompat from 1.3.1 to 1.4.2. Changelog

Fixes the following issue(s)

  • Fixes #

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@Isira-Seneviratne Isira-Seneviratne marked this pull request as ready for review July 21, 2022 02:23
@TacoTheDank
Copy link
Member

This bump should be fine on its own. I've dabbled with updating this and the others already but haven't gotten around to it for some reason. You stole my job, but I suppose that's what I get for taking so long lol.

For the team, here's the changelog: https://developer.android.com/jetpack/androidx/releases/appcompat

@opusforlife2
Copy link
Collaborator

You stole my job

Capitalism.

@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Stypox Stypox merged commit 8a774dc into TeamNewPipe:dev Aug 3, 2022
@Isira-Seneviratne Isira-Seneviratne deleted the Update_AppCompat branch August 3, 2022 23:41
@Stypox Stypox mentioned this pull request Aug 27, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants