Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ExoPlayer to 2.18.0 #8536

Merged
merged 2 commits into from
Jul 13, 2022
Merged

Conversation

TacoTheDank
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Updated ExoPlayer 2.17.1 -> 2.18.0 (changelog)

I tested on my device and everything seemed to work fine. Feel free to test yourselves, though.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@Stypox
Copy link
Member

Stypox commented Jun 23, 2022

You might have had some rebasing issues, since some of the changes are unrelated and undo some details of #8153

@AudricV AudricV added the player Issues related to any player (main, popup and background) label Jun 23, 2022
@TacoTheDank
Copy link
Member Author

TacoTheDank commented Jun 26, 2022

You might have had some rebasing issues, since some of the changes are unrelated and undo some details of #8153

I always keep my branches up-to-date; it simply looks like some PRs were merged while I was initially making this PR. No rebasing issues here! I have updated the PR.

All changes in this PR are to fix new ExoPlayer deprecations. I have double checked them to be sure.

I have also updated the YoutubeHttpDataSource note to 2.18.0 (there were no real changes in upstream). Just as a note, this class will need to be kept up-to-date with future upstream changes if (and inevitably when) they occur.

@Redirion
Copy link
Member

thank you for the PR! Please make sure that we opt out of the diagnostics with ExoPlayer.Builder.setUsePlatformDiagnostics(false)

around line 515

@TacoTheDank
Copy link
Member Author

Done 👍

@sonarcloud
Copy link

sonarcloud bot commented Jul 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@Redirion Redirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Play, Pause, Mediabutton, Subtitles. Looks all good to me. Thanks again

@Redirion Redirion merged commit 93b913e into TeamNewPipe:dev Jul 13, 2022
@TacoTheDank TacoTheDank deleted the bumpExoPlayer branch July 14, 2022 01:25
@TacoTheDank
Copy link
Member Author

TacoTheDank commented Jul 14, 2022

Will this be a potential issue?: google/ExoPlayer#10381

@Stypox
Copy link
Member

Stypox commented Jul 14, 2022

It could, but we will probably have time to update to the next version before the next NewPipe release, so it shouldn't be a problem.

@TacoTheDank
Copy link
Member Author

Mm, hopefully.

@TacoTheDank TacoTheDank mentioned this pull request Jul 14, 2022
5 tasks
@Stypox Stypox mentioned this pull request Aug 27, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
player Issues related to any player (main, popup and background)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants