Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ConstraintLayout, Room libraries #7954

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

TacoTheDank
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Update ConstraintLayout 2.1.2 -> 2.1.3 (changelog)
  • Update Room 2.4.1 -> 2.4.2 (changelog)

These are rather inconsequential patch releases compared to the larger minor releases that other AndroidX libraries have. I'll work on getting those upgraded in other PRs of course.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@sonarcloud
Copy link

sonarcloud bot commented Feb 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@litetex litetex self-requested a review February 27, 2022 17:11
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Building + Testing didn't reveal any problems.

@litetex litetex merged commit e1197f7 into TeamNewPipe:dev Feb 28, 2022
@TacoTheDank TacoTheDank deleted the bumpInconsequential branch March 1, 2022 20:50
@TacoTheDank TacoTheDank added the codequality Improvements to the codebase to improve the code quality label Mar 25, 2022
@Stypox Stypox mentioned this pull request Apr 16, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants