Have fast seek overlay arc go under system ui #7898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stypox
force-pushed
the
regression-arc
branch
from
ea0481e
to
da12b92
Compare
|
Kudos, SonarCloud Quality Gate passed! |
triallax
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
In #7893 I added padding (equal to the window insets) to the fast seek overlay just as it was done with the player overlays (play-pause, brightness, ...). But as you can see in the "Before" screenshot below, that caused the fast-seek arc to not go under the system ui. This PR instead applies to the fast seek overlay negative margins, for each side respectively equal to minus the window inset of the opposite side. This way the view covers all of the player (overflowing on some sides, but that's not important) and its center still coincides with the center of other controls (which is a requirement, since we don't want #7731).
Before/After Screenshots/Screen Record
APK testing
I tested on API 19 and API 30 and it worked fine.
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence