Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some gradle deprecations #7678

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Conversation

TacoTheDank
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Update gradle wrapper 7.3.1 -> 7.3.3
  • Update Checkstyle 9.2 -> 9.2.1 (changelog)
  • Fixed some well-hidden deprecations (found here)

APK testing

Shouldn't be necessary.

Due diligence

@AudricV AudricV added the codequality Improvements to the codebase to improve the code quality label Jan 21, 2022
@triallax
Copy link
Contributor

Update gradle wrapper 7.3.1 -> 7.3.3

Just to clarify, you're upgrading Gradle, not the Gradle wrapper.

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gradle changes look good according to the documentation, though it's strange that they deprecate things without giving an explanation and an alternative method themselves. The checkstyle update also looks good, as there have only been internal bugfixes in 9.2.1: https://checkstyle.sourceforge.io/releasenotes.html. The app builds just fine, both here and on my pc.

@Stypox Stypox merged commit ac53196 into TeamNewPipe:dev Jan 25, 2022
@TacoTheDank
Copy link
Member Author

Thanks :)

@TacoTheDank TacoTheDank deleted the gradleDeprecations branch January 26, 2022 15:36
This was referenced Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants