Change pitch by semitones

[haklc]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Added optional semitone slider to Playback Parameter Dialog
• Added toggle to enable/disable this slider
• Added code that enables use of semitones along percent for pitch adjustment

Before/After Screenshots/Screen Record

• Before:

• After:
  
  

Fixes the following issue(s)

• Fixes Option to change pitch by semitones #7322

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

• I read the contribution guidelines.

[opusforlife2]

Woohoo! I think this is a really good idea. Thanks for thinking of it and working on it!

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[Stypox]

Good work! I will probably use this feature. Code mostly looks good, thank you :-)

Note for maintainers (nothing wrong with this PR): PlaybackParameterDialog should use ConstraintLayout and view binding (if the latter is not possible it should at least be completely refactored) in a future PR

[opusforlife2]

@haklc Instead of the dev branch, please name your branch something meaningful: https://github.com/TeamNewPipe/NewPipe/blob/dev/.github/CONTRIBUTING.md#creating-a-pull-request-pr

[haklc]

@haklc Instead of the dev branch, please name your branch something meaningful: https://github.com/TeamNewPipe/NewPipe/blob/dev/.github/CONTRIBUTING.md#creating-a-pull-request-pr

Will do.

[Stypox]

@opusforlife2 @haklc now it's too late to change the branch's name... Let's keep it dev, it's not really a problem, just remember to use a different name next time ;-)

[haklc]

@Stypox I've resolved your comments, the code should now be good to go :)

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[Stypox]

Thank you :-D
Code looks good, and I tested again and found no issues. Will be merged next release :-)

[haklc]

Awesome! :D

[litetex]

Keep in mind that this will negate the optimizations done in #7363.

I also think that the class needs an overhaul, however this is not part of this issue.