Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readd sonar CI job #7552

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Readd sonar CI job #7552

merged 1 commit into from
Dec 20, 2021

Conversation

XiangRongLin
Copy link
Collaborator

@XiangRongLin XiangRongLin commented Dec 19, 2021 •
edited
Loading

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Add sonar CI job back which was commented out
    Sonar secret token still exists from before and I think no other stuff needs to be changed

This comes in result of #5926

Due diligence

@XiangRongLin XiangRongLin added the CI Issue is related to the CI label Dec 19, 2021
litetex
litetex approved these changes Dec 19, 2021
View reviewed changes
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

See also https://sonarcloud.io/project/overview?id=TeamNewPipe_NewPipe

@XiangRongLin XiangRongLin merged commit 96eb142 into TeamNewPipe:dev Dec 20, 2021
@XiangRongLin XiangRongLin deleted the readd_sonar branch December 20, 2021 08:32
This was referenced Feb 11, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@litetex litetex litetex approved these changes

Assignees
No one assigned
Labels
CI Issue is related to the CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XiangRongLin @litetex