Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable media tunneling on Philips QM16XE #7497

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Disable media tunneling on Philips QM16XE #7497

merged 1 commit into from
Dec 6, 2021

Conversation

Redirion
Copy link
Member

@Redirion Redirion commented Dec 4, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@Redirion Redirion added player Issues related to any player (main, popup and background) device/software specific Issues that only happen on some devices or with some specific hardware/software labels Dec 4, 2021
litetex
litetex approved these changes Dec 4, 2021
View reviewed changes
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think we should find a general solution here in the future (like exposing the media tunneling option and not hiding it inside some debug options).

@litetex litetex merged commit 4fc9443 into dev Dec 6, 2021
@litetex litetex deleted the fix-qm16xe branch December 6, 2021 19:54
@Redirion Redirion mentioned this pull request Feb 14, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@litetex litetex litetex approved these changes

Assignees
No one assigned
Labels
device/software specific Issues that only happen on some devices or with some specific hardware/software player Issues related to any player (main, popup and background)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Seekbar - Graphics stuttering and sound gone issue
2 participants
@Redirion @litetex