Show an alert dialog when no appropriate file manager was found

[litetex]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• See the linked issue for more details about the problem
• If no file-manager (or SAF compatible) file manager is installed on a device now an alert shows up

Before/After Screenshots/Screen Record

• Before: <App crashed>
• After:
  
  ← Android 10+

Fixes the following issue(s)

• Fixes Catch ActivityNotFoundException (file-manager) and display a meaningful error #7113 and more than 10 other issues where users managed to have no file-manager.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

• I read the contribution guidelines.

How to test this?

To test this you have to get rid of all your file-managers (may led to data loss or other side effects). This may require disabling system apps.

I strongly recommend doing this on an emulator only!

How to do it on an emulated Android 10 device:

• Wipe all data from that device
• Open a shell/commandline
• Connect to the emulator using adb shell (ensure that you are connected to the correct device!)
• Get into the sudo mode: su
• Disable Androids default file-manager: pm disable com.android.documentsui
  → Now you can deploy NewPipe to the emulator and check if the changes work as expected

[triallax]

Now those no-file-manager-installed issues shall be opened no more.

Note: I think all usages of "file-picker" and "directory-picker" should be unhyphenated (as in "file picker" and "directory picker"), same with "download-settings".

_{sorry for nitpicking}

[Stypox]

Isn't there too much code duplication? Why not just add a launchAndCheck(ActivityResultLauncher<Intent>, Intent, Context) function to NoFileManagerHelper, that does the try-catch?

[TacoTheDank]

Kinda makes you wonder how they managed to install the app in the first place, huh? 😉

[Stypox]

The code looks good to me, except from the string ;-)

[litetex]

@Stypox

Kinda makes you wonder how they managed to install the app in the first place, huh? 😉

Black magic I guess 😆 (they likely installed it with F-Droid which requires no file-manager for installation)

[Stypox]

Great :-)