Added the 'Show Channel Details' menu item to the Queue long press menu #7222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a method in NavigationHelper that opens the channel fragment using an Intent to MainActivity instead of replacing fragments.
|
Does this PR fix any issues? So we can close them? |
Didn't find any open ones and I thought this was simple enough to not make a new issue. Should I? |
|
No everything fine then 😄 |
litetex
requested changes
Oct 12, 2021
Probably related open issue: |
|
@Symbian9 Channel description actually means 'About' tab of the channel, not the whole channel feed. Moreover, that issue addresses an enhancement for search results, not play queue. |
litetex
previously approved these changes
Oct 15, 2021
litetex
approved these changes
Oct 15, 2021
This was referenced Nov 30, 2021
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Show Channel Detailsmenu item tomenu_play_queue_item.xml.Before/After Screenshots/Screen Record
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence