Update AndroidX Media library to 1.4.x

[TacoTheDank]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Update AndroidX Media 1.3.1 -> 1.4.2 (changelog)
• Add a new action from version 1.3.0-beta01, which adds support for the set playback speed command. Please advise on whether this change should be kept.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

• I read the contribution guidelines.

[litetex]

• Add a new action from version 1.3.0-beta01, which adds support for the set playback speed command. Please advise on whether this change should be kept.

How can I test this change / Where can I see it?
Is this only available for specific android versions?

[TacoTheDank]

How can I test this change / Where can I see it? Is this only available for specific android versions?

I do not know if it is visible anywhere or can be tested, which is why I'm asking if it really needs to be kept. Perhaps it could be utilized in some way. However in hindsight I probably should've just asked in the PR before making that change.

[litetex]

Documentation/Use cases for this feature are really rare.
I tried to search for "ACTION_SET_PLAYBACK_SPEED" but only got ~1k results when googling... no stackoverflow post etc with a practical implementation.
The only helpful result is this one from ExoPlayer: google/ExoPlayer#8229

I think all the available actions are for the notification (I don't know what it's called correctly) that is visible when e.g. using the background-player:

As there is no "change playback speed action" I would strongly push for removing the ACTION_SET_PLAYBACK_SPEED.

[TacoTheDank]

@litetex Makes sense to me, thanks! Will remove, then.

[litetex]

I think there is something weird happening with this dependency update.

Every time I installed the apk/cleared all data/(sometimes)started the apk it had massive sound stuttering/speed up (while video was normal) until I set the speed/pitch of a video or the audio run out of buffer.

Tested on the following devices:

• Emulator - Pixel 3a Android 11 (API 30) ❌ Bug occurred
• Emulator - Pixel 3a Android 12 (API 31) ❌ Bug occurred
• Huawei P20lite Android 9 (API 28) ✔️ Couldn't reproduce problem

The latest release (0.21.10) is also working fine on the emulators.
Maybe we have to update ExoPlayer?

Can someone cross-check if this is also happening on other devices?

[tsiflimagas]

I couldn't reproduce the problem on my device, Xiaomi Redmi note 8.

[TacoTheDank]

I couldn't reproduce the problem on my device, Xiaomi Redmi note 8.

As a note for future reference, it is pretty much standard protocol to also share the Android version of the device :) what was yours?

[tsiflimagas]

Oh, excuse me, I'll keep it in mind :). I'm on a11 (custom ROM).

[litetex]

@TacoTheDank
I also had the problem yesterday in when using another git-branch. So I guess it's either the emulator or something got cached while building.
Anyway, if no further problems pop-up and nobody else manages to reviews this PR, I will re-test it on my real device and eventually merge it after the next release is out.

If then also other people get problems we can simply revert the commit and everything is fine 😄

[TacoTheDank]

@litetex Sounds good to me. I don't think I noticed any problems myself on my Android 10 device.

[litetex]

Tested it again and was unable to reproduce any problems now.

[TacoTheDank]

Thanks :)

[Pentaphon]

Seems like ExoPlayer is moving into AndroidX Media:

Exoplayer was previously hosted in a separate ExoPlayer GitHub project. In AndroidX Media its package name is androidx.media3.exoplayer. We plan to continue to maintain and release the ExoPlayer GitHub project for a while to give apps time to migrate.