Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not considering nullability when comparing getAudioTrackType #10909

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

Stypox
Copy link
Member

@Stypox Stypox commented Mar 27, 2024

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

AudioStream.getAudioTrackType() is correctly marked as being @Nullable in the extractor. However, the nullability was not considered when comparing audio streams in getAudioTrackNameComparator. I fixed this and checked neighboring get*Comparator functions, but those were already correct.

To check that this is in fact working, use this video, as suggested in the issue: https://www.youtube.com/watch?v=mKdjycj-7eE

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

Copy link

sonarcloud bot commented Mar 27, 2024

Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, did not test the changes

@Stypox Stypox merged commit 81220f9 into TeamNewPipe:dev Mar 28, 2024
7 of 9 checks passed
@davotoula
Copy link

404 on the pull request artifact.

Artifact download URL: https://github.com/TeamNewPipe/NewPipe/actions/runs/8454126340/artifacts/1363446442

@Stypox
Copy link
Member Author

Stypox commented Mar 28, 2024

@davotoula It works for me. Make sure you are logged in to GitHub when you open the link.

@davotoula
Copy link

Logged in it works. Thanks.

Issue resolved 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug downloader Issue is related to the downloader player Issues related to any player (main, popup and background)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when trying to play/download some streams (failure to sort streams)
4 participants