Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream avatar bug #10517

Closed

Conversation

mannith-narayan
Copy link

@mannith-narayan mannith-narayan commented Oct 27, 2023

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • I took some lines off the code where a drawable_image was rendered and made final, even though there were other images rendered from cache.
  • I also added a column in the 'streams' table in the database, to accommodate the storage of urls of channel avatar. I used the methods written in ImageStrategy.class to convert List to String URLs.
  • Due to adding a column for the table 'streams' in the database, I had to migrate the database version from DB_VER_7 to DB_VER_8.

Before/After Screenshots/Screen Record

  • Before: before
  • After: after

Fixes the following issue(s)

APK testing

Due diligence

Comment on lines -1485 to -1488
final Drawable buddyDrawable =
AppCompatResources.getDrawable(activity, R.drawable.placeholder_person);
binding.detailSubChannelThumbnailView.setImageDrawable(buddyDrawable);
binding.detailUploaderThumbnailView.setImageDrawable(buddyDrawable);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the research! You correctly identified these problematic lines to remove. However, I don't think we need to add the streamAvatar to the database. Could you explain why you did so? Maybe I'm missing something.
In the meantime I opened #10581 which supersedes this one.

@Stypox Stypox closed this Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Channel icon on stream details disappear sometimes
2 participants