Fix selection of wrong languages in language picker #10406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
..ing language picker to select wrong languages
|
Kudos, SonarCloud Quality Gate passed!
|
AudricV
added
bug
6 tasks
6 tasks
AudricV
changed the title
This was referenced Oct 5, 2023
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Fix Language Selector Bug introduced by #10250 , by placing Uchinaguchi Language correctly in language selector settings.
Fixes:
Language Selector Bug
Description:
In App language Content Settings, when I choose Punjabi, app language actually changes to Polish after restart (that means language picker picking up the lower placed language instead). App shows selected language Punjabi, even though app is now in Polish language.
Try changing any language after
ItalianJapanese in language selector settings, bug will be noticeable except last few languages.Tested on:
Device: Samsung Galaxy A22 5G
OS: Android 13 OneUI 5.0
App Version: 0.25.2
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence