Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to disable tracking of last searches #4006

Merged

Conversation

christophlehmann
Copy link
Contributor

@christophlehmann christophlehmann commented Apr 14, 2024

What this pr does

It introduces plugin.tx_solr.search.lastSearches.mode = disabled and in the 2nd commit set it to be new default

How to test

  • Set the TypoScript.
  • Make a search, that returns a result
  • See no tracked keywords in database

Fixes: #4003

Copy link
Collaborator

@dkd-kaehm dkd-kaehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christophlehmann
Thanks for that feature we'll merge that soonish.

@dkd-kaehm dkd-kaehm force-pushed the f-4003-lastsearches-tracking branch from d637973 to 8e079fc Compare May 8, 2024 07:31
@dkd-kaehm dkd-kaehm force-pushed the main branch 2 times, most recently from af047de to 8fc413f Compare May 16, 2024 15:31
Christoph Lehmann added 2 commits May 17, 2024 09:36
Currently last searches are always tracked, even if not displayed.

This introduces the new tracking mode 'disabled' to disable it.

plugin.tx_solr.search.lastSearches.mode = disabled

Relates: TYPO3-Solr#4003
@dkd-kaehm dkd-kaehm force-pushed the f-4003-lastsearches-tracking branch from 8e079fc to f2bcc6a Compare May 17, 2024 07:36
@dkd-kaehm dkd-kaehm merged commit 55efb3f into TYPO3-Solr:main May 17, 2024
1 check passed
dkd-kaehm pushed a commit to dkd-kaehm/ext-solr that referenced this pull request May 17, 2024
Currently last searches are always tracked, even if not displayed.

This introduces the new tracking mode 'disabled' to disable it.

plugin.tx_solr.search.lastSearches.mode = disabled

Relates: TYPO3-Solr#4003
Ports: TYPO3-Solr#4006
dkd-kaehm pushed a commit that referenced this pull request May 17, 2024
Currently last searches are always tracked, even if not displayed.

This introduces the new tracking mode 'disabled' to disable it.

plugin.tx_solr.search.lastSearches.mode = disabled

Relates: #4003
Ports: #4006
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Be able to disable tracking of visitors search inputs
2 participants