Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Wrong range string generation in DateRange facet #4087

Open
derhansen opened this issue Jun 6, 2024 · 1 comment
Open

[BUG] Wrong range string generation in DateRange facet #4087

derhansen opened this issue Jun 6, 2024 · 1 comment

Comments

@derhansen
Copy link
Contributor

Describe the bug
The range string in the DateRange facet is generated, so that the time of the start- and enddate is 0000 (00:00). For the enddate, this is wrong and should be 2359 (23:59), so items for the whole enddate are selected.

Used versions (please complete the following information):

  • TYPO3 Version: 12.4
  • EXT:solr Version: 12.x
  • Used Apache Solr Version: 9.6
@derhansen derhansen mentioned this issue Jun 6, 2024
Closed
@dkd-kaehm
Copy link
Collaborator

@derhansen
Please check the Tests.

derhansen added a commit to derhansen/ext-solr that referenced this issue Jun 7, 2024
@derhansen
[BUGFIX] Fix range string calculation in DateRange facet
65263c6 
This change fixes the range string calculation, so items for
the given date are included until 23:59 of the target end date.

Fixes: TYPO3-Solr#4087
@derhansen derhansen mentioned this issue Jun 7, 2024
Merged
2 tasks
dkd-kaehm pushed a commit to derhansen/ext-solr that referenced this issue Jul 4, 2024
@derhansen @dkd-kaehm
[BUGFIX] Fix range string calculation in DateRange facet
1aa1214 
This change fixes the range string calculation, so items for
the given date are included until 23:59 of the target end date.

Fixes: TYPO3-Solr#4087
dkd-kaehm pushed a commit to dkd-kaehm/ext-solr that referenced this issue Jul 4, 2024
@derhansen @dkd-kaehm
[BUGFIX] Fix range string calculation in DateRange facet
0f51cb0 
This change fixes the range string calculation, so items for
the given date are included until 23:59 of the target end date.

Fixes: TYPO3-Solr#4087
Ports: TYPO3-Solr#4090
@dkd-kaehm dkd-kaehm mentioned this issue Jul 4, 2024
Merged
dkd-kaehm pushed a commit to dkd-kaehm/ext-solr that referenced this issue Jul 4, 2024
@derhansen @dkd-kaehm
[BUGFIX] Fix range string calculation in DateRange facet
329c6da 
This change fixes the range string calculation, so items for
the given date are included until 23:59 of the target end date.

Fixes: TYPO3-Solr#4087
Ports: TYPO3-Solr#4090
@dkd-kaehm dkd-kaehm mentioned this issue Jul 4, 2024
Merged
dkd-kaehm pushed a commit that referenced this issue Jul 4, 2024
@derhansen @dkd-kaehm
[BUGFIX] Fix range string calculation in DateRange facet
ae4a299 
This change fixes the range string calculation, so items for
the given date are included until 23:59 of the target end date.

Fixes: #4087
Ports: #4090
dkd-kaehm pushed a commit that referenced this issue Jul 4, 2024
@derhansen @dkd-kaehm
[BUGFIX] Fix range string calculation in DateRange facet
a08b0da 
This change fixes the range string calculation, so items for
the given date are included until 23:59 of the target end date.

Fixes: #4087
Ports: #4090
dkd-kaehm pushed a commit that referenced this issue Jul 4, 2024
@derhansen @dkd-kaehm
[BUGFIX] Fix range string calculation in DateRange facet
fef3dde 
This change fixes the range string calculation, so items for
the given date are included until 23:59 of the target end date.

Fixes: #4087
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUGFIX] Fix range string calculation in DateRange facet derhansen/ext-solr
2 participants
@derhansen @dkd-kaehm