[BUGFIX] Add empty array defaults in SearchFormViewHelper #4042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for creating this PR! |
dkd-kaehm
force-pushed
the
main
branch
3 times, most recently
from
af047de
to
8fc413f
Compare
dkd-kaehm
force-pushed
the
bugfix/4040-searchformviewhelper_breaks_on_empty_queryparams_and_body_in_request
branch
from
b55d50d
to
26ca9f2
Compare
Adds empty array defaults in SearchFormViewHelper::getExistingSearchParameters to prevent TYPO3 TypeError. Fixes: TYPO3-Solr#4040
dkd-kaehm
force-pushed
the
bugfix/4040-searchformviewhelper_breaks_on_empty_queryparams_and_body_in_request
branch
from
26ca9f2
to
438e0eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pr does
Adds empty array defaults in SearchFormViewHelper::getExistingSearchParameters to prevent TYPO3 TypeError.
How to test
Setup ext:solr with "keepExistingParametersForNewSearches = 1"
Fixes: #4040