[BUG] SearchFormViewHelper breaks on empty QueryParams and Body in Request.

[davidjakob]

SearchFormViewHelper breaks the Page if there are no QueryParameters in the Request.

            $arguments = $request->getQueryParams()[$pluginNamespace];
            ArrayUtility::mergeRecursiveWithOverrule($arguments, $request->getParsedBody()[$pluginNamespace]);

A Check resolves this Problem:

            $arguments = $request->getQueryParams()[$pluginNamespace] ?? [];
            $bodyArguments = $request->getParsedBody()[$pluginNamespace] ?? [];
            ArrayUtility::mergeRecursiveWithOverrule($arguments, $bodyArguments);

Used versions (please complete the following information):

• TYPO3 Version: 12 latest
• EXT:solr Version: 12.0.3

[dkd-kaehm]

Please provide a Pull-Request for that issue.

[simplethingsgmbh]

I can confirm that behaviour.
A warning is thrown in debug mode:

PHP Warning: Undefined array key "tx_solr" in vendor/apache-solr-for-typo3/solr/Classes/ViewHelpers/SearchFormViewHelper.php line 148

The parameter keepExistingParametersForNewSearches has to be set for this error.