Feature noise lf pulse #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simon-Stone
suggested changes
May 20, 2021
TdsModel.h
Outdated
| @@ -297,6 +297,9 @@ class TdsModel | |||
| void getSectionFlow(int sectionIndex, double &inflow, double &outflow); | |||
| double getSectionPressure(int sectionIndex); | |||
|
|
|||
| void calcNoiseSample(NoiseSource* s, double ampThreshold); | |||
There was a problem hiding this comment.
Why does this need to be public?
There was a problem hiding this comment.
This was to be able to use the noise source function already implemented, but it turns out that this function is too complex for what we need so I found it simpler to just generate random numbers.
There was a problem hiding this comment.
Great, then I'd say just make it private again.
TdsModel.h
Outdated
| @@ -297,6 +297,9 @@ class TdsModel | |||
| void getSectionFlow(int sectionIndex, double &inflow, double &outflow); | |||
| double getSectionPressure(int sectionIndex); | |||
|
|
|||
| void calcNoiseSample(NoiseSource* s, double ampThreshold); | |||
| void incrementPosition() { position++; } | |||
There was a problem hiding this comment.
Is this function needed?
There was a problem hiding this comment.
Same as before, this was to use the noise function.
There was a problem hiding this comment.
Got it, so we can just remove it, then.
Simon-Stone
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.