forked from Expensify/App
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "Merge pull request Expensify#30169 from software-mansion-labs…
…/ts-migration/personal-details-utils" This reverts commit e17c313, reversing changes made to 9973d8f.
- Loading branch information
1 parent
c31b51b
commit 2b0c23f
Showing
13 changed files
with
241 additions
and
230 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,222 @@ | ||
| import lodashGet from 'lodash/get'; | ||
| import Onyx from 'react-native-onyx'; | ||
| import _ from 'underscore'; | ||
| import ONYXKEYS from '@src/ONYXKEYS'; | ||
| import * as LocalePhoneNumber from './LocalePhoneNumber'; | ||
| import * as Localize from './Localize'; | ||
| import * as UserUtils from './UserUtils'; | ||
|
|
||
| let personalDetails = []; | ||
| let allPersonalDetails = {}; | ||
| Onyx.connect({ | ||
| key: ONYXKEYS.PERSONAL_DETAILS_LIST, | ||
| callback: (val) => { | ||
| personalDetails = _.values(val); | ||
| allPersonalDetails = val; | ||
| }, | ||
| }); | ||
|
|
||
| /** | ||
| * @param {Object | Null} passedPersonalDetails | ||
| * @param {Array | String} pathToDisplayName | ||
| * @param {String} [defaultValue] optional default display name value | ||
| * @returns {String} | ||
| */ | ||
| function getDisplayNameOrDefault(passedPersonalDetails, pathToDisplayName, defaultValue = '') { | ||
| const displayName = lodashGet(passedPersonalDetails, pathToDisplayName); | ||
|
|
||
| return displayName || defaultValue || Localize.translateLocal('common.hidden'); | ||
| } | ||
|
|
||
| /** | ||
| * Given a list of account IDs (as number) it will return an array of personal details objects. | ||
| * @param {Array<number>} accountIDs - Array of accountIDs | ||
| * @param {Number} currentUserAccountID | ||
| * @param {Boolean} shouldChangeUserDisplayName - It will replace the current user's personal detail object's displayName with 'You'. | ||
| * @returns {Array} - Array of personal detail objects | ||
| */ | ||
| function getPersonalDetailsByIDs(accountIDs, currentUserAccountID, shouldChangeUserDisplayName = false) { | ||
| return _.chain(accountIDs) | ||
| .filter((accountID) => !!allPersonalDetails[accountID]) | ||
| .map((accountID) => { | ||
| const detail = allPersonalDetails[accountID]; | ||
|
|
||
| if (shouldChangeUserDisplayName && currentUserAccountID === detail.accountID) { | ||
| return { | ||
| ...detail, | ||
| displayName: Localize.translateLocal('common.you'), | ||
| }; | ||
| } | ||
|
|
||
| return detail; | ||
| }) | ||
| .value(); | ||
| } | ||
|
|
||
| /** | ||
| * Given a list of logins, find the associated personal detail and return related accountIDs. | ||
| * | ||
| * @param {Array<string>} logins Array of user logins | ||
| * @returns {Array} - Array of accountIDs according to passed logins | ||
| */ | ||
| function getAccountIDsByLogins(logins) { | ||
| return _.reduce( | ||
| logins, | ||
| (foundAccountIDs, login) => { | ||
| const currentDetail = _.find(personalDetails, (detail) => detail.login === login); | ||
| if (!currentDetail) { | ||
| // generate an account ID because in this case the detail is probably new, so we don't have a real accountID yet | ||
| foundAccountIDs.push(UserUtils.generateAccountID(login)); | ||
| } else { | ||
| foundAccountIDs.push(Number(currentDetail.accountID)); | ||
| } | ||
| return foundAccountIDs; | ||
| }, | ||
| [], | ||
| ); | ||
| } | ||
|
|
||
| /** | ||
| * Given a list of accountIDs, find the associated personal detail and return related logins. | ||
| * | ||
| * @param {Array<number>} accountIDs Array of user accountIDs | ||
| * @returns {Array<string>} - Array of logins according to passed accountIDs | ||
| */ | ||
| function getLoginsByAccountIDs(accountIDs) { | ||
| return _.reduce( | ||
| accountIDs, | ||
| (foundLogins, accountID) => { | ||
| const currentDetail = _.find(personalDetails, (detail) => Number(detail.accountID) === Number(accountID)) || {}; | ||
| if (currentDetail.login) { | ||
| foundLogins.push(currentDetail.login); | ||
| } | ||
| return foundLogins; | ||
| }, | ||
| [], | ||
| ); | ||
| } | ||
|
|
||
| /** | ||
| * Given a list of logins and accountIDs, return Onyx data for users with no existing personal details stored | ||
| * | ||
| * @param {Array<string>} logins Array of user logins | ||
| * @param {Array<number>} accountIDs Array of user accountIDs | ||
| * @returns {Object} - Object with optimisticData, successData and failureData (object of personal details objects) | ||
| */ | ||
| function getNewPersonalDetailsOnyxData(logins, accountIDs) { | ||
| const optimisticData = {}; | ||
| const successData = {}; | ||
| const failureData = {}; | ||
|
|
||
| _.each(logins, (login, index) => { | ||
| const accountID = accountIDs[index]; | ||
|
|
||
| if (_.isEmpty(allPersonalDetails[accountID])) { | ||
| optimisticData[accountID] = { | ||
| login, | ||
| accountID, | ||
| avatar: UserUtils.getDefaultAvatarURL(accountID), | ||
| displayName: LocalePhoneNumber.formatPhoneNumber(login), | ||
| }; | ||
|
|
||
| /** | ||
| * Cleanup the optimistic user to ensure it does not permanently persist. | ||
| * This is done to prevent duplicate entries (upon success) since the BE will return other personal details with the correct account IDs. | ||
| */ | ||
| successData[accountID] = null; | ||
| } | ||
| }); | ||
|
|
||
| return { | ||
| optimisticData: [ | ||
| { | ||
| onyxMethod: Onyx.METHOD.MERGE, | ||
| key: ONYXKEYS.PERSONAL_DETAILS_LIST, | ||
| value: optimisticData, | ||
| }, | ||
| ], | ||
| successData: [ | ||
| { | ||
| onyxMethod: Onyx.METHOD.MERGE, | ||
| key: ONYXKEYS.PERSONAL_DETAILS_LIST, | ||
| value: successData, | ||
| }, | ||
| ], | ||
| failureData: [ | ||
| { | ||
| onyxMethod: Onyx.METHOD.MERGE, | ||
| key: ONYXKEYS.PERSONAL_DETAILS_LIST, | ||
| value: failureData, | ||
| }, | ||
| ], | ||
| }; | ||
| } | ||
|
|
||
| /** | ||
| * Applies common formatting to each piece of an address | ||
| * | ||
| * @param {String} piece - address piece to format | ||
| * @returns {String} - formatted piece | ||
| */ | ||
| function formatPiece(piece) { | ||
| return piece ? `${piece}, ` : ''; | ||
| } | ||
|
|
||
| /** | ||
| * | ||
| * @param {String} street1 - street line 1 | ||
| * @param {String} street2 - street line 2 | ||
| * @returns {String} formatted street | ||
| */ | ||
| function getFormattedStreet(street1 = '', street2 = '') { | ||
| return `${street1}\n${street2}`; | ||
| } | ||
|
|
||
| /** | ||
| * | ||
| * @param {*} street - formatted address | ||
| * @returns {[string, string]} [street1, street2] | ||
| */ | ||
| function getStreetLines(street = '') { | ||
| const streets = street.split('\n'); | ||
| return [streets[0], streets[1]]; | ||
| } | ||
|
|
||
| /** | ||
| * Formats an address object into an easily readable string | ||
| * | ||
| * @param {OnyxTypes.PrivatePersonalDetails} privatePersonalDetails - details object | ||
| * @returns {String} - formatted address | ||
| */ | ||
| function getFormattedAddress(privatePersonalDetails) { | ||
| const {address} = privatePersonalDetails; | ||
| const [street1, street2] = getStreetLines(address.street); | ||
| const formattedAddress = formatPiece(street1) + formatPiece(street2) + formatPiece(address.city) + formatPiece(address.state) + formatPiece(address.zip) + formatPiece(address.country); | ||
|
|
||
| // Remove the last comma of the address | ||
| return formattedAddress.trim().replace(/,$/, ''); | ||
| } | ||
|
|
||
| /** | ||
| * @param {Object} personalDetail - details object | ||
| * @returns {String | undefined} - The effective display name | ||
| */ | ||
| function getEffectiveDisplayName(personalDetail) { | ||
| if (personalDetail) { | ||
| return LocalePhoneNumber.formatPhoneNumber(personalDetail.login) || personalDetail.displayName; | ||
| } | ||
|
|
||
| return undefined; | ||
| } | ||
|
|
||
| export { | ||
| getDisplayNameOrDefault, | ||
| getPersonalDetailsByIDs, | ||
| getAccountIDsByLogins, | ||
| getLoginsByAccountIDs, | ||
| getNewPersonalDetailsOnyxData, | ||
| getFormattedAddress, | ||
| getFormattedStreet, | ||
| getStreetLines, | ||
| getEffectiveDisplayName, | ||
| }; |
Oops, something went wrong.