Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Util types for special Omit cases #1121

Merged
merged 6 commits into from
Jun 7, 2021
Merged

Util types for special Omit cases #1121

merged 6 commits into from
Jun 7, 2021

Commits on Jun 4, 2021

  1. Add a handful of util type definitions, to adress flaws in built-in O… 

    …mit type
    @Stephen-ONeil
    Stephen-ONeil committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    ce98cc9 View commit details
    Browse the repository at this point in the history

  2. Add link to relevant PR for IndexTypeSafeOmit's motivation

    @Stephen-ONeil
    Stephen-ONeil committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    b4829e4 View commit details
    Browse the repository at this point in the history

  3. Replace IndexTypeSafeOmit with MUCH simpler SafeOmit util type. Even … 

    …fixed an edge case bug that I'd caught in IndexTypeSafeOmit and adds symbol support, nice
    @Stephen-ONeil
    Stephen-ONeil committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    1baef6d View commit details
    Browse the repository at this point in the history

  4. Disable no-unused-vars for line in util_types.d.ts

    @Stephen-ONeil
    Stephen-ONeil committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    732b344 View commit details
    Browse the repository at this point in the history

  5. Prettier-ignre line in util_types.d.ts that uses TypeScript syntax ou… 

    …r out of date prettier version doesn't understand
    @Stephen-ONeil
    Stephen-ONeil committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    d1176ee View commit details
    Browse the repository at this point in the history

  6. ... prettier 2.0 also had some sort of prettier-ignore bug it seems. … 

    …Add util_types.d.ts to .prettierignore for now, will remove that line on the prettier 2.3 branch
    @Stephen-ONeil
    Stephen-ONeil committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    4ded626 View commit details
    Browse the repository at this point in the history