-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove reqwest dependency #354
base: main
Are you sure you want to change the base?
Conversation
Converting to a draft for the time being for further consideration |
I think we'll probably move forward with this, but @diehuxx wondering if you can give it a look. Windows test seems to be failing so I'm guessing something in our TLS or TCP (or something else?) is causing issues specifically on Windows, so I'll get to the bottom of that. I may rework the The major win here is to get us off of OpenSSL entirely. Also it reduces the byte code file size by ~10% which is not insignificant. We're unable to get out of |
@KendallWeihe The failure is that we expect I suspect that Windows rust implementation of I'd be comfortable just updating the test to accept either error message. I added a commit doing this. |
7796874
to
f9e2032
Compare
Ok(json_value) | ||
} | ||
|
||
pub fn get_bytes_as_http_response(url: &str) -> Result<HttpResponse> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feel like we could just call this get
and it would be less confusing. get_bytes_as_http_response
sounds like i'm parsing the url
as an http response
No description provided.