Establish basic style analyzer rules

.editorconfig

@@ -12,19 +12,107 @@ csharp_indent_switch_labels = true
 csharp_indent_case_contents = true
 csharp_indent_labels = one_less_than_current
 
-# Globalization rules
-dotnet_code_quality.CA1305.excluded_symbol_names = T:System.Byte|T:System.SByte|T:System.Int16|T:System.UInt16|T:System.Int32|T:System.UInt32|T:System.Int64|T:System.UInt64|T:System.String|T:System.Text.StringBuilder|T:System.Convert
+# Style rules
+# Can't be in .globalconfig because dotnet format doesn't respect that https://github.com/dotnet/format/issues/1643
 
-dotnet_diagnostic.CA1305.severity = error
-dotnet_diagnostic.CA2101.severity = suggestion
+# Remove unnecessary cast
+dotnet_diagnostic.IDE0004.severity = warning
+# Remove unnecessary import
+dotnet_diagnostic.IDE0005.severity = warning
+# Use var instead of explicit type
+dotnet_diagnostic.IDE0007.severity = suggestion
+# Use explicit type instead of var
+dotnet_diagnostic.IDE0008.severity = suggestion
+# Inline variable declaration
+dotnet_diagnostic.IDE0018.severity = warning
+# Use pattern matching to avoid as followed by a null check
+dotnet_diagnostic.IDE0019.severity = warning
+# Use pattern matching to avoid is check followed by a cast (with variable)
+dotnet_diagnostic.IDE0020.severity = warning
+# Use expression body for methods
+dotnet_diagnostic.IDE0022.severity = suggestion
+# Use expression body for properties
+dotnet_diagnostic.IDE0025.severity = suggestion
+# Use expression body for indexers
+dotnet_diagnostic.IDE0026.severity = suggestion
+# Use expression body for accessors
+dotnet_diagnostic.IDE0027.severity = suggestion
+# Null check can be simplified
+dotnet_diagnostic.IDE0029.severity = warning
+# Null check can be simplified
+dotnet_diagnostic.IDE0030.severity = warning
+# Use null propagation
+dotnet_diagnostic.IDE0031.severity = warning
+# Use auto property
+dotnet_diagnostic.IDE0032.severity = suggestion
+# Simplify default expression
+dotnet_diagnostic.IDE0034.severity = suggestion
+# Use pattern matching to avoid is check followed by a cast (without variable)
+dotnet_diagnostic.IDE0038.severity = warning
+# Use is null check
+dotnet_diagnostic.IDE0041.severity = warning
+# Deconstruct variable declaration
+dotnet_diagnostic.IDE0042.severity = suggestion
+# dotnet_diagnostic.IDE0049.severity = error # see SA1121
+# Remove unused private member
+dotnet_diagnostic.IDE0051.severity = suggestion
+# Remove unread private member
+dotnet_diagnostic.IDE0052.severity = silent # TODO: should be warning imo, but there's too much violation currently
+# Use compound assignment
+dotnet_diagnostic.IDE0054.severity = warning
+# Use index operator
+dotnet_diagnostic.IDE0056.severity = warning
+# Use range operator
+dotnet_diagnostic.IDE0057.severity = warning
+# Use simple using statement
+dotnet_diagnostic.IDE0063.severity = suggestion
+# Make struct fields writable
+dotnet_diagnostic.IDE0064.severity = error
+# using directive placement
+dotnet_diagnostic.IDE0065.severity = error
+# Use switch expression
+dotnet_diagnostic.IDE0066.severity = suggestion
+# Use System.HashCode.Combine
+dotnet_diagnostic.IDE0070.severity = warning
+# Simplify interpolation
+dotnet_diagnostic.IDE0071.severity = suggestion
+# Use coalesce compound assignment
+dotnet_diagnostic.IDE0074.severity = suggestion
+# Use pattern matching
+dotnet_diagnostic.IDE0078.severity = suggestion
+# Convert typeof to nameof
+dotnet_diagnostic.IDE0082.severity = warning
+# Use pattern matching (not operator)
+dotnet_diagnostic.IDE0083.severity = warning
+# Simplify new expression
+dotnet_diagnostic.IDE0090.severity = suggestion
+# Remove unnecessary equality operator
+dotnet_diagnostic.IDE0100.severity = warning
+# Remove unnecessary discard
+dotnet_diagnostic.IDE0110.severity = warning
+# Simplify LINQ expression
+dotnet_diagnostic.IDE0120.severity = error
+# Namespace does not match folder structure
+dotnet_diagnostic.IDE0130.severity = silent # should be warning imo
+# Use tuple to swap values
+dotnet_diagnostic.IDE0180.severity = suggestion
+# Use UTF-8 string literal
+dotnet_diagnostic.IDE0230.severity = warning
+# Nullable directive is redundant
+dotnet_diagnostic.IDE0240.severity = warning
+# Nullable directive is unnecessary
+dotnet_diagnostic.IDE0241.severity = warning
+# Struct can be made 'readonly'
+dotnet_diagnostic.IDE0250.severity = suggestion
+# Use pattern matching
+dotnet_diagnostic.IDE0260.severity = suggestion
+# Use nameof
+dotnet_diagnostic.IDE0280.severity = error
 
-# Performance rules
-dotnet_code_quality.CA1826.exclude_ordefault_methods = true
+csharp_style_var_when_type_is_apparent = true
+csharp_style_var_elsewhere = true
 
-dotnet_diagnostic.CA1805.severity = silent
-dotnet_diagnostic.CA1822.severity = silent
-dotnet_diagnostic.CA1838.severity = suggestion
-
-# Usage rules
-dotnet_diagnostic.CA1816.severity = none
-dotnet_diagnostic.CA2201.severity = suggestion
+csharp_style_expression_bodied_methods = when_on_single_line
+csharp_style_expression_bodied_properties = when_on_single_line
+csharp_style_expression_bodied_indexers = when_on_single_line
+csharp_style_expression_bodied_accessors = when_on_single_line

.globalconfig

@@ -0,0 +1,18 @@
+is_global = true
+
+# Globalization rules
+dotnet_code_quality.CA1305.excluded_symbol_names = T:System.Byte|T:System.SByte|T:System.Int16|T:System.UInt16|T:System.Int32|T:System.UInt32|T:System.Int64|T:System.UInt64|T:System.String|T:System.Text.StringBuilder|T:System.Convert
+
+dotnet_diagnostic.CA1305.severity = error
+dotnet_diagnostic.CA2101.severity = suggestion
+
+# Performance rules
+dotnet_code_quality.CA1826.exclude_ordefault_methods = true
+
+dotnet_diagnostic.CA1805.severity = silent
+dotnet_diagnostic.CA1822.severity = silent
+dotnet_diagnostic.CA1838.severity = suggestion
+
+# Usage rules
+dotnet_diagnostic.CA1816.severity = none
+dotnet_diagnostic.CA2201.severity = suggestion

Common.props

@@ -6,6 +6,7 @@
 		<AnalysisModeReliability>Recommended</AnalysisModeReliability>
 		<AnalysisModePerformance>Recommended</AnalysisModePerformance>
 		<AnalysisModeUsage>Recommended</AnalysisModeUsage>
+		<EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
 		<CodeAnalysisRuleSet>$(MSBuildProjectDirectory)/../../Common.ruleset</CodeAnalysisRuleSet>
 		<ContinuousIntegrationBuild Condition=" '$(GITLAB_CI)' != '' Or '$(APPVEYOR)' != '' ">true</ContinuousIntegrationBuild>
 		<EnableNETAnalyzers>true</EnableNETAnalyzers>

src/BizHawk.BizInvoke/BizExvoker.cs

@@ -67,8 +67,7 @@ public DelegateStorage(Type type)
 
 				foreach (var a in methods)
 				{
-					MethodBuilder unused;
-					var delegateType = BizInvokeUtilities.CreateDelegateType(a.Info, a.Attr!.CallingConvention, typeBuilder, out unused).CreateType()!;
+					var delegateType = BizInvokeUtilities.CreateDelegateType(a.Info, a.Attr!.CallingConvention, typeBuilder, out _).CreateType()!;
 					DelegateTypes.Add(new StoredDelegateInfo(a.Info, delegateType, a.Attr.EntryPoint ?? a.Info.Name));
 				}
 				StorageType = typeBuilder.CreateType()!;

src/BizHawk.BizInvoke/CallingConventionAdapter.cs

@@ -167,7 +167,7 @@ static WaterboxAdapter()
 			{
 				WaterboxWrapper = OSTailoredCode.IsUnixHost
 					? new NativeConvention()
-					: (ICallingConventionAdapter)new MsHostSysVGuest();
+					: new MsHostSysVGuest();
 			}
 
 			private readonly Dictionary<Delegate, int>? _slots;
@@ -247,7 +247,7 @@ static MsHostSysVGuest()
 			public MsHostSysVGuest()
 			{
 				const int size = 4 * 1024 * 1024;
-				_memory = new((ulong)size);
+				_memory = new(size);
 				_refs = new WeakReference[size / BlockSize];
 			}
 

src/BizHawk.BizInvoke/MemoryBlock.cs

@@ -1,7 +1,5 @@
 using System;
 using System.IO;
-using System.Linq;
-using System.Runtime.InteropServices;
 using BizHawk.Common;
 
 namespace BizHawk.BizInvoke
@@ -19,7 +17,7 @@ public MemoryBlock(ulong size)
 			Size = WaterboxUtils.AlignUp(size);
 
 			_pal = OSTailoredCode.IsUnixHost
-				? (IMemoryBlockPal)new MemoryBlockLinuxPal(Size)
+				? new MemoryBlockLinuxPal(Size)
 				: new MemoryBlockWindowsPal(Size);
 			Start = _pal!.Start;
 			EndExclusive = Start + Size;

src/BizHawk.BizInvoke/MemoryViewStream.cs

@@ -1,6 +1,5 @@
 using System;
 using System.IO;
-using System.Runtime.InteropServices;
 using BizHawk.Common;
 
 namespace BizHawk.BizInvoke

src/BizHawk.BizInvoke/POSIXLibC.cs

@@ -1,8 +1,6 @@
 using System;
 using System.Runtime.InteropServices;
 
-using static BizHawk.BizInvoke.MemoryBlock;
-
 namespace BizHawk.BizInvoke
 {
 	public static class POSIXLibC

src/BizHawk.Bizware.BizwareGL/BitmapBuffer.cs

@@ -527,7 +527,7 @@ private static int NextHigher(int k)
 			k--;
 			for (var i = 1; i < 32; i <<= 1)
 			{
-				k = k | k >> i;
+				k |= k >> i;
 			}
 
 			var candidate = k + 1;

src/BizHawk.Bizware.Graphics/OpenGL/SDL2OpenGLContext.cs

@@ -1,7 +1,5 @@
 using System;
 
-using Silk.NET.OpenGL.Legacy;
-
 using static SDL2.SDL;
 
 namespace BizHawk.Bizware.Graphics

src/BizHawk.Client.Common/Api/Classes/EmuClientApi.cs

@@ -1,8 +1,6 @@
 using System;
 using System.Drawing;
 using System.IO;
-
-using BizHawk.Common;
 using BizHawk.Emulation.Common;
 
 namespace BizHawk.Client.Common

src/BizHawk.Client.Common/Api/Classes/JoypadApi.cs

@@ -58,7 +58,7 @@ public void Set(IReadOnlyDictionary<string, bool> buttons, int? controller = nul
 			// ALL button names with P{controller} prefixes
 			foreach (var button in _inputManager.ActiveController.ToBoolButtonNameList(controller))
 			{
-				Set(button, buttons.TryGetValue(button, out var state) ? state : (bool?) null, controller);
+				Set(button, buttons.TryGetValue(button, out var state) ? state : null, controller);
 			}
 		}
 

src/BizHawk.Client.Common/Api/Classes/MemoryApi.cs

@@ -3,7 +3,6 @@
 using System.Linq;
 
 using BizHawk.Common;
-using BizHawk.Common.BufferExtensions;
 using BizHawk.Emulation.Common;
 
 namespace BizHawk.Client.Common

src/BizHawk.Client.Common/Api/HttpCommunication.cs

@@ -1,5 +1,3 @@
-#pragma warning disable CA2007
-
 using System;
 using System.Collections.Generic;
 using System.Net.Http;

src/BizHawk.Client.Common/DisplayManager/DisplayManagerBase.cs

@@ -763,7 +763,6 @@ private FilterProgram UpdateSourceInternal(JobInfo job)
 			}
 
 			var videoProvider = job.VideoProvider;
-			var glTextureProvider = videoProvider as IGLTextureProvider;
 			var simulate = job.Simulate;
 			var chainOutsize = job.ChainOutsize;
 
@@ -824,7 +823,7 @@ private FilterProgram UpdateSourceInternal(JobInfo job)
 			Texture2d videoTexture = null;
 			if (!simulate)
 			{
-				if (glTextureProvider != null && _gl.DispMethodEnum == EDispMethod.OpenGL)
+				if (videoProvider is IGLTextureProvider glTextureProvider && _gl.DispMethodEnum == EDispMethod.OpenGL)
 				{
 					// FYI: this is a million years from happening on n64, since it's all geriatric non-FBO code
 					videoTexture = _gl.WrapGLTexture2d(new(glTextureProvider.GetGLTexture()), bufferWidth, bufferHeight);

src/BizHawk.Client.Common/DisplayManager/IBlitter.cs

@@ -1,7 +1,5 @@
 using System.Drawing;
 
-using BizHawk.Bizware.BizwareGL;
-
 namespace BizHawk.Client.Common
 {
 	/// <summary>

src/BizHawk.Client.Common/DisplayManager/OSDManager.cs

@@ -3,8 +3,6 @@
 using System.Text;
 using System.Drawing;
 using System.Collections.Generic;
-
-using BizHawk.Bizware.BizwareGL;
 using BizHawk.Emulation.Common;
 
 namespace BizHawk.Client.Common

src/BizHawk.Client.Common/lua/CommonLibs/SQLiteLuaLibrary.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Collections.Generic;
 using System.ComponentModel;
-using System.Linq;
 
 // ReSharper disable UnusedMember.Global
 namespace BizHawk.Client.Common

src/BizHawk.Client.Common/lua/LuaHelperLibs/NESLuaLibrary.cs

@@ -143,7 +143,7 @@ public void SetDisplayBackground(bool show)
 					nhs.DispBackground = show;
 					Settings = nhs;
 					break;
-				case QuickNES.QuickNESSettings _:
+				case QuickNES.QuickNESSettings:
 					return;
 				default:
 					throw new InvalidOperationException();
@@ -209,7 +209,7 @@ public void SetScanlines(int top, int bottom, bool pal = false)
 
 					Settings = nhs;
 					break;
-				case QuickNES.QuickNESSettings _:
+				case QuickNES.QuickNESSettings:
 					return;
 				default:
 					throw new InvalidOperationException();

src/BizHawk.Client.Common/movie/tasproj/StateDictionary.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Collections;
 using System.Collections.Generic;
-using System.Text;
 using System.IO;
 using BizHawk.Common;
 

src/BizHawk.Client.Common/movie/tasproj/TasLagLog.cs

@@ -15,7 +15,7 @@ public bool? this[int frame]
 			get
 			{
 				var result = _lagLog.TryGetValue(frame, out var lag);
-				return result ? (bool?)lag : null;
+				return result ? lag : null;
 			}
 
 			set

src/BizHawk.Client.Common/rewind/ZeldaWinder.cs

@@ -1,6 +1,5 @@
 using System;
 using System.IO;
-using System.Runtime.InteropServices;
 using System.Threading.Tasks;
 using BizHawk.Common;
 using BizHawk.Emulation.Common;

src/BizHawk.Client.Common/tools/Cheat.cs

@@ -67,9 +67,9 @@ public Cheat(Cheat cheat)
 
 		public long? Address => _watch.Address;
 
-		public int? Value => IsSeparator ? (int?)null : _val;
+		public int? Value => IsSeparator ? null : _val;
 
-		public bool? BigEndian => IsSeparator ? (bool?)null : _watch.BigEndian;
+		public bool? BigEndian => IsSeparator ? null : _watch.BigEndian;
 
 		public int? Compare => _compare.HasValue && !IsSeparator ? _compare : null;
 
@@ -304,7 +304,7 @@ public override int GetHashCode()
 		public static bool operator ==(Cheat a, Cheat b)
 		{
 			// If one is null, but not both, return false.
-			if ((object)a == null || (object)b == null)
+			if (a is null || b is null)
 			{
 				return false;
 			}
@@ -320,7 +320,7 @@ public override int GetHashCode()
 		public static bool operator ==(Cheat a, Watch b)
 		{
 			// If one is null, but not both, return false.
-			if ((object)a == null || (object)b == null)
+			if (a is null || b is null)
 			{
 				return false;
 			}

src/BizHawk.Client.Common/tools/Watch/ByteWatch.cs

@@ -141,7 +141,7 @@ public string FormatValue(byte val)
 		/// Get a string representation of difference
 		/// between current value and the previous one
 		/// </summary>
-		public override string Diff => $"{_value - (short)_previous:+#;-#;0}";
+		public override string Diff => $"{_value - _previous:+#;-#;0}";
 
 		/// <summary>
 		/// Returns true if the Watch is valid, false otherwise