-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for AzureAI client service #188
base: main
Are you sure you want to change the base?
Conversation
@adityasugandhi |
fixed azure_ad_token provider in AzureOpenAI
@hmehta92 I have fixed the azure_ad_token provider call, and line 163 to 180 serves for AzureOpenAI, where line 183 to 200 is for AsyncAzureOpenAI. |
Hi, what's the status of this PR? Do you need help @adityasugandhi for anything? I would like to see this feature implemented asap along with AWS Bedrock as they could serve more companies as they usually go with cloud providers when the other part of the cloud is hosted there. |
@chainyo I am still waiting for the review from the repo owner. @liyin2015 Sure, I will start looking into AWS Bedrock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(1) Please add azure as a optional package in lazy_import
(2) please add a test file in adalflow/tests
(3) add azure in the pyproject.toml as an extra package
chat_completion_parser: Callable[[Completion], Any] = None, | ||
input_type: Literal["text", "messages"] = "text", | ||
): | ||
r"""It is recommended to set the OPENAI_API_KEY environment variable instead of passing it as an argument. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so it does not have it only api_key? why using openai_api_key?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liyin2015 I have made changes as mentioned in the comments
@liyin2015 I have made changes |
log_probs = [] | ||
for c in completion.choices: | ||
content = c.logprobs.content | ||
print(content) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adityasugandhi I think you forgot to remove print statement here on line 90.
Added Support Azure AI, client serivce #92
Now you can use either OPEN_AI_KEY or you can use Azure identity service to directly authenticate to your end points using credentials