Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Credit Memo] Fix shipping cost calculation #187

Closed

Conversation

Tomanhez
Copy link
Contributor

No description provided.

@Tomanhez Tomanhez requested a review from a team as a code owner February 10, 2020 09:52
@Tomanhez Tomanhez force-pushed the shiping-cost-texes-calculation branch from b28a57d to ba2afcb Compare February 10, 2020 10:01
Then it should have sequential number generated from current date
And it should contain 1 "Galaxy Post" shipment with "10.00" net value, "1.50" tax amount and "11.50" gross value in "USD" currency
And it should be issued in "United States" channel
And its total should be "11.50" in "USD" currency
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add before this step:

And it should contain a tax item "15%" with amount "1.50" in "USD" currency

$shipment = $this->shipmentRepository->find(['id' => $unitRefund->id()]);
Assert::notNull($shipment);
/** @var AdjustmentInterface $adjustment */
$adjustment = $shipment->getUnits()->first()->getAdjustments()->first();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that the first adjustment of the first unit of a shipment always contains information about shipping costs?

@grimzy
Copy link

grimzy commented Sep 22, 2020

While this PR is now outdated; the issue persists; it doesn't seems that we can refund the shipping tax (or rather the order's 'tax' adjustment); even when refunding every item in the order.

Additionally (consequently?), when refunding every item in the order, the order's status remains partially_refunded. Is this because the adjustments on the order are not refunded?

Am I using the refund plugin wrong? Is there a configuration I'm missing somewhere? How do we refund the taxes associated with an order?

@GSadee
Copy link
Member

GSadee commented Mar 17, 2021

Closing in favour of #264

@GSadee GSadee closed this Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants