Update new service confirutations

Sylius · Jun 10, 2021 · e566409 · e566409
1 parent 7c50eb6
commit e566409
Show file tree

Hide file tree

Showing 7 changed files with 17 additions and 31 deletions.
diff --git a/src/Resources/config/admin_routing.yml b/src/Resources/config/admin_routing.yml
@@ -51,16 +51,6 @@ sylius_refund_admin_credit_memo_download:
     defaults:
         _controller: Sylius\RefundPlugin\Action\Admin\DownloadCreditMemoAction
 
-sylius_refund_order_refund_payment_list:
-    path: /orders/{orderNumber}/refund-payments
-    methods: [GET]
-    defaults:
-        _controller: sylius_refund.controller.refund_payment:indexAction
-        _sylius:
-            template: "@SyliusRefundPlugin/Order/Admin/RefundPayment/list.html.twig"
-            repository:
-                method: findByOrderNumber
-                arguments: $orderNumber
 
 sylius_refund_complete_refund_payment:
     path: /orders/{orderNumber}/refund-payments/{id}/complete

diff --git a/src/Resources/config/services.xml b/src/Resources/config/services.xml
@@ -33,6 +33,7 @@
             <argument type="service" id="Sylius\RefundPlugin\Provider\UnitRefundedTotalProviderInterface" />
             <argument type="service" id="Sylius\RefundPlugin\Checker\UnitRefundingAvailabilityCheckerInterface" />
             <argument type="service" id="sylius.repository.order" />
+            <argument type="service" id="sylius_refund.repository.refund_payment" />
             <tag name="twig.extension"/>
         </service>
 

diff --git a/src/Resources/config/services/listeners.xml b/src/Resources/config/services/listeners.xml
@@ -25,10 +25,5 @@
             <argument>@SyliusRefundPlugin/Order/Admin/creditMemos.html.twig</argument>
             <tag name="kernel.event_listener" event="sonata.block.event.sylius.admin.order.show.after_summary" method="onBlockEvent" />
         </service>
-
-        <service id="sylius_refund_plugin.block_event_listener.order_show.refund_payments" class="Sylius\Bundle\UiBundle\Block\BlockEventListener">
-            <argument>@SyliusRefundPlugin/Order/Admin/refundPayments.html.twig</argument>
-            <tag name="kernel.event_listener" event="sonata.block.event.sylius.admin.order.show.after_summary" method="onBlockEvent" />
-        </service>
     </services>
 </container>
diff --git a/src/Resources/views/SyliusAdminBundle/Order/Show/_refund.html.twig b/src/Resources/views/SyliusAdminBundle/Order/Show/_refund.html.twig
@@ -1,12 +1,12 @@
 {% import '@SyliusAdmin/Common/Macro/money.html.twig' as money %}
-{% set refund_payments = get_all_refund_payments_by_order_number(order.number) %}
+{% set refund_payments = get_all_refund_payments_by_order(order) %}
     {% if refund_payments|length > 0 %}
         {% include '@SyliusAdmin/Order/Label/PaymentState/' ~ order.paymentState ~ '.html.twig' with { 'value': 'sylius.ui.' ~ order.paymentState, 'attached': true } %}
         <h3 class="ui dividing header">{{ 'sylius_refund.ui.refund_payments'|trans }}</h3>
         <div class="ui relaxed divided list">
             {% for refund_payment in refund_payments %}
-                <div class="item">
-                    <div class="right floated content">
+                <div class="item" {{ sylius_test_html_attribute('refund') }}>
+                    <div class="right floated content" {{ sylius_test_html_attribute('refund-status') }}>
                         {% include '@SyliusRefundPlugin/Common/Label/refundPaymentState.html.twig' with {'data': refund_payment.state} %}
                     </div>
                     <i class="large payment icon"></i>
@@ -19,7 +19,7 @@
                         </div>
                     </div>
                     {% if sm_can(refund_payment, 'complete', 'sylius_refund_refund_payment') %}
-                        <form action="{{ path('sylius_refund_complete_refund_payment', {'orderNumber': refund_payment.orderNumber, 'id': refund_payment.id}) }}" method="POST">
+                        <form action="{{ path('sylius_refund_complete_refund_payment', {'orderNumber': refund_payment.orderNumber, 'id': refund_payment.id}) }}" method="POST" {{ sylius_test_html_attribute('refund-button') }}>
                             <button class="ui icon labeled yellow loadable button"><i class="check icon"></i> {{ 'sylius.ui.complete'|trans }}</button>
                         </form>
                     {% endif %}

diff --git a/src/Twig/OrderRefundsExtension.php b/src/Twig/OrderRefundsExtension.php
@@ -73,8 +73,8 @@ public function getFunctions(): array
                 [$this, 'getUnitRefundLeft']
             ),
             new TwigFunction(
-                'get_all_refund_payments_by_order_number',
-                [$this, 'getAllRefundPaymentsByOrderNumber']
+                'get_all_refund_payments_by_order',
+                [$this, 'getAllRefundPaymentsByOrder']
             )
         ];
     }
@@ -102,8 +102,8 @@ public function getRefundedTotal(string $orderNumber): int
         return ($this->orderRefundedTotalProvider)($order);
     }
 
-    public function getAllRefundPaymentsByOrderNumber(string $orderNumber): array
+    public function getAllRefundPaymentsByOrder(OrderInterface $order): array
     {
-        return $this->refundPaymentRepository->findBy(['orderNumber' => $orderNumber]);
+        return $this->refundPaymentRepository->findBy(['order' => $order]);
     }
 }
diff --git a/tests/Application/templates/bundles/SyliusAdminBundle/Order/Show/_refund.html.twig b/tests/Application/templates/bundles/SyliusAdminBundle/Order/Show/_refund.html.twig
@@ -1,12 +1,12 @@
 {% import '@SyliusAdmin/Common/Macro/money.html.twig' as money %}
-{% set refund_payments = get_all_refund_payments_by_order_number(order.number) %}
+{% set refund_payments = get_all_refund_payments_by_order(order) %}
     {% if refund_payments|length > 0 %}
         {% include '@SyliusAdmin/Order/Label/PaymentState/' ~ order.paymentState ~ '.html.twig' with { 'value': 'sylius.ui.' ~ order.paymentState, 'attached': true } %}
         <h3 class="ui dividing header">{{ 'sylius_refund.ui.refund_payments'|trans }}</h3>
         <div class="ui relaxed divided list">
             {% for refund_payment in refund_payments %}
-                <div class="item">
-                    <div class="right floated content">
+                <div class="item" {{ sylius_test_html_attribute('refund') }}>
+                    <div class="right floated content" {{ sylius_test_html_attribute('refund-status') }}>
                         {% include '@SyliusRefundPlugin/Common/Label/refundPaymentState.html.twig' with {'data': refund_payment.state} %}
                     </div>
                     <i class="large payment icon"></i>
@@ -19,7 +19,7 @@
                         </div>
                     </div>
                     {% if sm_can(refund_payment, 'complete', 'sylius_refund_refund_payment') %}
-                        <form action="{{ path('sylius_refund_complete_refund_payment', {'orderNumber': refund_payment.orderNumber, 'id': refund_payment.id}) }}" method="POST">
+                        <form action="{{ path('sylius_refund_complete_refund_payment', {'orderNumber': refund_payment.orderNumber, 'id': refund_payment.id}) }}" method="POST" {{ sylius_test_html_attribute('refund-button') }}>
                             <button class="ui icon labeled yellow loadable button"><i class="check icon"></i> {{ 'sylius.ui.complete'|trans }}</button>
                         </form>
                     {% endif %}

diff --git a/tests/Behat/Page/Admin/Order/ShowPage.php b/tests/Behat/Page/Admin/Order/ShowPage.php
@@ -34,12 +34,12 @@ public function hasRefundsButton(): bool
 
     public function hasRefundPaymentsWithStatus(int $count, string $status): bool
     {
-        $refundPayments = $this->getDocument()->findAll('css', '#refund-payments tbody tr');
+        $refundPayments = $this->getDocument()->findAll('css', '[data-test-refund-status]');
 
         $refundPaymentsWithStatus = 0;
         /** @var NodeElement $refundPayment */
         foreach ($refundPayments as $refundPayment) {
-            if (strpos($refundPayment->getText(), $status)) {
+            if ($refundPayment->getText() == $status) {
                 $refundPaymentsWithStatus++;
             }
         }
@@ -49,7 +49,7 @@ public function hasRefundPaymentsWithStatus(int $count, string $status): bool
 
     public function completeRefundPayment(int $number): void
     {
-        $refundPayments = $this->getDocument()->findAll('css', '#refund-payments tbody tr');
+        $refundPayments = $this->getDocument()->findAll('css', '[data-test-refund-button]');
 
         /** @var NodeElement $refundPayment */
         $refundPayment = $refundPayments[$number];
@@ -59,7 +59,7 @@ public function completeRefundPayment(int $number): void
 
     public function canCompleteRefundPayment(int $number): bool
     {
-        $refundPayments = $this->getDocument()->findAll('css', '#refund-payments tbody tr');
+        $refundPayments = $this->getDocument()->findAll('css', '[data-test-refund]');
 
         /** @var NodeElement $refundPayment */
         $refundPayment = $refundPayments[$number];