bug #263 Check proper state during resolving order refunded state (GS…

…adee) This PR was merged into the 1.0-dev branch. Discussion ---------- Fixes #253 Commits ------- f651c0f Check proper state during resolving order refunded state
Sylius · Mar 10, 2021 · e233082 · e233082
2 parents 4e6da18 + f651c0f
commit e233082
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/spec/StateResolver/OrderFullyRefundedStateResolverSpec.php b/spec/StateResolver/OrderFullyRefundedStateResolverSpec.php
@@ -41,7 +41,7 @@ function it_applies_refund_transition_on_order(
     ): void {
         $orderRepository->findOneByNumber('000222')->willReturn($order);
         $orderFullyRefundedTotalChecker->isOrderFullyRefunded($order)->willReturn(true);
-        $order->getState()->willReturn(OrderInterface::STATE_NEW);
+        $order->getPaymentState()->willReturn(OrderPaymentStates::STATE_PAID);
 
         $stateMachineFactory->get($order, OrderPaymentTransitions::GRAPH)->willReturn($stateMachine);
         $stateMachine->apply(OrderPaymentTransitions::TRANSITION_REFUND)->shouldBeCalled();
@@ -59,7 +59,7 @@ function it_does_nothing_if_order_state_is_fully_refunded(
     ): void {
         $orderRepository->findOneByNumber('000222')->willReturn($order);
         $orderFullyRefundedTotalChecker->isOrderFullyRefunded($order)->willReturn(true);
-        $order->getState()->willReturn(OrderPaymentStates::STATE_REFUNDED);
+        $order->getPaymentState()->willReturn(OrderPaymentStates::STATE_REFUNDED);
 
         $stateMachineFactory->get(Argument::any())->shouldNotBeCalled();
 
@@ -80,7 +80,7 @@ function it_does_nothing_if_order_is_not_fully_refunded(
         $this->resolve('000222');
     }
 
-    function it_throws_exception_if_there_is_no_order_with_given_number(OrderRepositoryInterface $orderRepository): void
+    function it_throws_an_exception_if_there_is_no_order_with_given_number(OrderRepositoryInterface $orderRepository): void
     {
         $orderRepository->findOneByNumber('000222')->willReturn(null);
 

diff --git a/src/StateResolver/OrderFullyRefundedStateResolver.php b/src/StateResolver/OrderFullyRefundedStateResolver.php
@@ -47,7 +47,7 @@ public function resolve(string $orderNumber): void
 
         if (
             !$this->orderFullyRefundedTotalChecker->isOrderFullyRefunded($order) ||
-            OrderPaymentStates::STATE_REFUNDED === $order->getState()
+            OrderPaymentStates::STATE_REFUNDED === $order->getPaymentState()
         ) {
             return;
         }