Refactor taxRateProvider

Sylius · Mar 16, 2021 · c6415d4 · c6415d4
1 parent 757def6
commit c6415d4
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/spec/Provider/TaxRateProviderSpec.php b/spec/Provider/TaxRateProviderSpec.php
@@ -55,4 +55,21 @@ function it_returns_null_if_there_is_no_adjustment_with_details_with_tax_rate_am
 
         $this->provide($orderItemUnit)->shouldReturn(null);
     }
+
+    function it_throws_exception_if_order_item_unit_has_more_than_1_tax_adjustment(
+        OrderItemUnitInterface $orderItemUnit,
+        AdjustmentInterface $firstTaxAdjustment,
+        AdjustmentInterface $secondTaxAdjustment
+
+    ): void {
+        $orderItemUnit
+            ->getAdjustments(AdjustmentInterface::TAX_ADJUSTMENT)
+            ->willReturn(new ArrayCollection([$firstTaxAdjustment->getWrappedObject(), $secondTaxAdjustment->getWrappedObject()]))
+        ;
+
+        $this
+            ->shouldThrow(\InvalidArgumentException::class)
+            ->during('provide', [$orderItemUnit])
+        ;
+    }
 }
diff --git a/src/Provider/TaxRateProvider.php b/src/Provider/TaxRateProvider.php
@@ -7,6 +7,7 @@
 use Doctrine\Common\Collections\Collection;
 use Sylius\Component\Core\Model\OrderItemUnitInterface;
 use Sylius\RefundPlugin\Entity\AdjustmentInterface;
+use Webmozart\Assert\Assert;
 
 final class TaxRateProvider implements TaxRateProviderInterface
 {
@@ -15,6 +16,8 @@ public function provide(OrderItemUnitInterface $orderItemUnit): ?string
         /** @var Collection|AdjustmentInterface[] $taxAdjustments */
         $taxAdjustments = $orderItemUnit->getAdjustments(AdjustmentInterface::TAX_ADJUSTMENT);
 
+        Assert::maxCount($taxAdjustments, 1, 'Every Order Item Unit Should have max 1 tax adjustment');
+
         if ($taxAdjustments->isEmpty() || !key_exists('taxRateAmount', $taxAdjustments->first()->getDetails())) {
             return null;
         }