Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(client): start migrating to react-router@v6 #3028

Merged
merged 6 commits into from
Feb 13, 2024
Merged

refactor(client): start migrating to react-router@v6 #3028

merged 6 commits into from
Feb 13, 2024

Conversation

leafty
Copy link
Member

@leafty leafty commented Feb 9, 2024 •
edited
Loading

Starts the process to incrementally upgrade react-router to v6.

Docs:

Added the v5->6 compatibility packages and migrated routes:

  • on the style guide
  • on project settings

/deploy renku=release-0.48.x

@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3028.dev.renku.ch

@leafty leafty marked this pull request as ready for review February 12, 2024 14:58
@leafty leafty requested a review from a team as a code owner February 12, 2024 14:58
lorenzo-cavazzi
lorenzo-cavazzi approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! 🚀

P.S. Feel free to decide in favor or against the suggestion since it has no impact on the code

client/src/App.jsx
@@ -28,6 +28,8 @@ import { Helmet } from "react-helmet";
import { Redirect, useLocation } from "react-router";
import { Route, Switch } from "react-router-dom";
import { ToastContainer } from "react-toastify";
// eslint-disable-next-line spellcheck/spell-checker
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we temporarily add compat to the spell-checker whitelist? This will be used in quite some pages

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I'll add it next time

@leafty leafty merged commit 46506b5 into main Feb 13, 2024
18 checks passed
@leafty leafty deleted the leafty/react-router-migration branch February 13, 2024 11:45
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

@leafty leafty mentioned this pull request Feb 15, 2024
Merged
leafty added a commit that referenced this pull request May 28, 2024
@leafty
refactor(client): some migration step for react-router@v6
64c3001 
Setup CompatRoute for some top-level routes.

Setup CompatRoute for:
* `/search`

See:
* #3028
* #3041
@leafty leafty mentioned this pull request May 28, 2024
Merged
leafty added a commit that referenced this pull request May 30, 2024
@leafty
refactor(client): some migration step for react-router@v6 (#3151)
4a1f2ac 
Setup CompatRoute for some top-level routes.

Setup CompatRoute for:
* `/search`
* `/inactive-kg-projects`
* `/projects`
* `/projects/starred`
* `/projects/all`
* `/projects/new`

See also:
* #3028
* #3041
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenzo-cavazzi lorenzo-cavazzi lorenzo-cavazzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leafty @RenkuBot @lorenzo-cavazzi