fix(client): correctly show loading state on a project's workflows tab #2493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can access the deployment of this PR at https://renku-ci-ui-2493.dev.renku.ch |
lorenzo-cavazzi
requested changes
Apr 25, 2023
There was a problem hiding this comment.
If you load the project page straight into the /workflows tab, you still briefly get the warning as in the following gif. I tried with this link:
https://renku-ci-ui-2493.dev.renku.ch/projects/lorenzo.cavazzi.tech/flights-tutorial-2022-04-19/workflows
Suggestion: in the redux store, together with the migration.core.backendAvailable boolean, we store a fetched property initialized as null (Reference).
Perhaps checking if no !fetched might help? Not sure tho if that's the broken piece or something else needs to be checked.
leafty
commented
Apr 25, 2023
lorenzo-cavazzi
approved these changes
Apr 26, 2023
leafty
had a problem deploying
to
renku-ci-ui-2493
GitHub Actions
Failure
leafty
deleted the
leafty/2492-fix-workflow-unsupported-message-flashing
branch
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2492.
/deploy #persist #cypress