Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloud Backend test solution #26

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

Cloud Backend test solution #26

wants to merge 32 commits into from

Conversation

himabindugit
Copy link

PR with proper commits and messages

@himabindugit
chore: adding lint tools
a7a9456
@himabindugit
chore: add prettier config file
9d6485d
@himabindugit
chore: add husky with linting pre-commit pre-push commit-msg hooks
c58e2ea
@himabindugit
chore: add deploy supported scripts
2b7c7e2
@himabindugit
chore: added lambda handler
ced73c9
@himabindugit
chore: package files for dependencies
72687e7
@himabindugit
chore: added sample.env for reference
c6e5e5f
@himabindugit
chore: add documentation folder with screenshots
8533093
@himabindugit
chore: typecript complier config files
c3a7fba
@himabindugit
chore: graphql schema file
aa3ff3b
@himabindugit
chore: gitignore file
9781b06
@himabindugit
chore: mocha configuration file
3b85cbf
@himabindugit
chore: implementation around env files and global configs
cee1771
@himabindugit
chore: tests utilities
23d4a92
@himabindugit
chore: unit tests
f2f5d74
@himabindugit
chore: integration tests
2fd5f1b
@himabindugit
chore: playing around express context and tracing
cfc64d1
@himabindugit
chore: file to calculate coordinates using node-geocoder
6579e80
@himabindugit
chore: starting apollo server file
0072c8c
@himabindugit
chore: logging plugin for logs for more info
6acfa44
@himabindugit
chore: coordinate resolvers
dec91e8
@himabindugit
chore: starting apollo server file
081e625
@himabindugit
chore: typedefs
ed291c4
@himabindugit himabindugit mentioned this pull request Aug 12, 2022
Closed
rleonr-sf
rleonr-sf reviewed Aug 16, 2022
View reviewed changes
.eslintignore
@@ -0,0 +1 @@
node_modules/*
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @himabindugit! I'm looking forward to hearing your thoughts following my review :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rleonr-sf thanks for the detailed review, i have tried my best to answer your questions, i can take an another look tomorrow just to make i haven't missed anything.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @himabindugit, I appreciate the time invested in this submission. We'll get in touch with you with an update soon

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rleonr-sf Just FYI - I have pushed more changes. I have just included screenshots (success and error cases) using my GraphQL API, am happy to upload interactive demo with using GraphQL API.

documentation/2_HowToDeploy.md Show resolved Hide resolved
documentation/2_HowToDeploy.md Show resolved Hide resolved
documentation/3_HowToRun.md Outdated Show resolved Hide resolved
documentation/5_TechStack.md Outdated Show resolved Hide resolved
src/resolvers/coordinates.ts Outdated Show resolved Hide resolved
src/test/integration/check.test.ts Show resolved Hide resolved
src/calculateCoordinates.ts Outdated Show resolved Hide resolved
src/test/unit/resolvers.test.ts Show resolved Hide resolved
src/test/unit/calculateCoordinates.test.ts Show resolved Hide resolved
@himabindugit
Copy link
Author

@marcelino-sf Hi, I forgot to ask one question in our call today. Code challenge README mentioned about The API should follow typical GraphQL API design patterns, other than the standards I have already followed - is there anything specific about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleonr-sf rleonr-sf rleonr-sf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@himabindugit @rleonr-sf