-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/DJSv14 #1227
feature/DJSv14 #1227
Conversation
I think we should create a new branch for this, then push to master v5 once completed. |
So how do you want to add Spotify, Apple Music and Deezer plugins? I have a few options:
|
Good idea. Perfect opportunity for ts rewrite |
unfortunately I had already started with JS. |
Note: this will go up as 5.1 |
Scylla was added in 26a57fb but will be switched out for a PostgreSQL DB with Prisma ORM |
Prisma supports different DB architectures, mostly SQL, but also MongoDB. |
Will this still be hostable on Replit or shall we have to do on-site hosting? |
I haven't tested it on any deployment ready services and i don't recommend replit anyway. The bot runs on anything that supports docker or that is docker configurable so you're free to test it however you like. If you're interested in just the bot (without DB and playlist command) then you can extract the djs-bot folder and use that directly, as it is completely modular and separable from the docker compose structure. |
I know this might be a half solution but you could try the method described in this forum post: |
@BioCla The new Replit uses NixOS. That means that Docker can't be used because they phased it out. Before, Replit used to be a gigantic Docker container with many Docker instances running. Since it now uses Nix, I can't use the Docker option. I do not want the DB functionality, that's why I'm asking whether this new version of the bot supports Replit? |
yes... If you want to set it up yourself |
v5.1 now has the dashboard as well, matching v5.0. Upcoming features: if anyone has suggestions reply to this or create a thread/discussion |
nonono, It's running Ubuntu (ewww), and yes it have Nix as package manager instead. However if you put pkgs.docker in replit.nix deps, it installs Docker but doesn't make Docker working properly. Since Replit doesn't give you root access, I think you should configure rootless docker (pain) |
Hey mate and maintainers :) I might be misunderstanding something, but according to this readme, it seems I can't configure my own Lavalink server, only the one preconfigured in the It would be awesome, if you could make it a Docker ENV, so you could choose your own, since I have mine hosted behind a reverse proxy, and I would like it to keep it that way, instead of using the "default" |
@vp-en
as stated in the main README.md:
This implies that you can indeed remove the lavalink service if it doesn't suit your needs but you would still need to modify the appropriate node configuration in the |
Ah cool, so there'll still be a |
@BioCla One of the reasons I liked v5 is because it had buttons. It would be pointless to create a v5.1 without buttons The player needs the buttons for they simplified the work in addition to the pause, play, stop, and volume commands |
I'll take that as a suggestion. I was already planning on reimplementing them under a different dress: I'll try to reimplement it as you suggested as well |
@BioCla I know right now I might sound like pushing too much, but the lyrics command doesn't return the lyrics for a song that is longer 4096 chars. Ideally it should return them but say "Truncated...." |
Thanks for letting me know, I'll fix it as soon as possible. It used to already be as you said but it seems it got reimplemented somewhere along the restructuring of the command |
Thanks |
…ard (#151) chore(deps-dev): bump @types/react from 18.2.31 to 18.2.32 in /dashboard
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.8.8 to 20.8.9. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…#152) chore(deps-dev): bump @types/node from 20.8.8 to 20.8.9 in /dashboard
# Draft ## Please describe the changes this PR makes and why it should be merged: ## Status and versioning classification: <!-- Please move lines that apply to you out of the comment: - Code changes have been tested against the Discord API, or there are no code changes - I know how to update typings and have done so, or typings don't need updating - This PR changes the library's interface (methods or parameters added) - This PR includes breaking changes (methods removed or renamed, parameters moved or removed) - This PR **only** includes non-code changes, like changes to documentation, README, etc. -->
Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 18.2.32 to 18.2.33. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: "@types/react" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…ard (#154) Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 18.2.32 to 18.2.33. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@types/react&package-manager=npm_and_yarn&previous-version=18.2.32&new-version=18.2.33)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
## Please describe the changes this PR makes and why it should be merged: If a user tries to add a playlist with the ``/play`` and ``/playlists play`` command, the addTrack function will only receive one argument(tracks). The addTrack function takes a player and a tracklist, and adds the tracks to the player. ## Status and versioning classification: <!-- Please move lines that apply to you out of the comment: - Code changes have been tested against the Discord API, or there are no code changes - I know how to update typings and have done so, or typings don't need updating - This PR changes the library's interface (methods or parameters added) - This PR includes breaking changes (methods removed or renamed, parameters moved or removed) - This PR **only** includes non-code changes, like changes to documentation, README, etc. -->
## Please describe the changes this PR makes and why it should be merged: ## Status and versioning classification: - Code changes have been tested against the Discord API, or there are no code changes - I know how to update typings and have done so, or typings don't need updating
## Please describe the changes this PR makes and why it should be merged: ## Status and versioning classification: - Code changes have been tested against the Discord API, or there are no code changes - I know how to update typings and have done so, or typings don't need updating
New version available at: https://github.com/wtfnotavailable/Discord-MusicBot |
Please describe the changes this PR makes and why it should be merged:
Implements DJSv14.
Contains Major changes, will be going up as a separate version
Read:
#1225
#1223
The code has been almost completely refactored, keeping the same basic structure but reorganizing the Libraries, adding functionality and modularity.
The bot has also been (optionally) containerized, using docker compose contexts, allowing the bot to be developed on any platform.
Tasks:
v5.1 Beta
Implemented features:
and some more...
v5.2 Beta
v5.3 Full release
Future updates:
v6.0:
if anyone has suggestions reply to this or create a thread/discussion
PR Status
Status and versioning classification:
The update is ready to be merged whenever