Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove cli #362

Merged
merged 7 commits into from
Jun 7, 2023
Merged

chore: remove cli #362

merged 7 commits into from
Jun 7, 2023

Conversation

guilhem-barthes
Copy link
Contributor

@guilhem-barthes guilhem-barthes commented Jun 5, 2023 •
edited
Loading

Related PR

Summary

Remove substra.cli and substra.sdk.Client.from_config_file().

Notes

Fixes FL-489

Please check if the PR fulfills these requirements

  • If necessary, the changelog has been updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • The commit message follows the conventional commit specification
  • For any breaking changes, companion PRs have been opened on the following repositories:

@linear
Copy link

linear bot commented Jun 5, 2023

FL-489 Remove the CLI

Context and user need:

The CLI is never used. Let's remove it.

Functional spec:
Remove the CLI and the client.fromconfig_file()function.

Technical spec:
Remove the feature.

Acceptance criteria:
Remove it

@guilhem-barthes guilhem-barthes changed the title Chore/remove cli chore: remove cli Jun 5, 2023
@guilhem-barthes guilhem-barthes mentioned this pull request Jun 5, 2023
Merged
2 tasks
@guilhem-barthes guilhem-barthes marked this pull request as ready for review June 5, 2023 11:05
@guilhem-barthes guilhem-barthes requested a review from a team as a code owner June 5, 2023 11:05
@ThibaultFy
Copy link
Member

/e2e --tests sdk --benchmarks mnist

@Owlfred
Copy link

Owlfred commented Jun 5, 2023 •
edited
Loading

End to end tests: ✔️ SUCCESS

ThibaultFy
ThibaultFy reviewed Jun 5, 2023
View reviewed changes
Copy link
Member

@ThibaultFy ThibaultFy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, love the -1000 lines !!

CHANGELOG.md Outdated Show resolved Hide resolved
tests/sdk/test_config.py Outdated Show resolved Hide resolved
ThibaultFy
ThibaultFy reviewed Jun 5, 2023
View reviewed changes
Copy link
Member

@ThibaultFy ThibaultFy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last comment and will be good :)

CHANGELOG.md Outdated Show resolved Hide resolved
@guilhem-barthes
chore: remove substra.cli
c990a0b 
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
@guilhem-barthes
chore: remove client.from_config_file()
fbe3055 
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
@guilhem-barthes
fix: remove references to bin/generate_cli_documentation.py
e60be2a 
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
@guilhem-barthes
docs: changelog
5105ca4 
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
@guilhem-barthes
fix: apply feedback
078b64a 
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
@guilhem-barthes
chore: remove duplicate checks
e1c9d92 
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
@guilhem-barthes
docs: apply feedback
7dd9041 
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
ThibaultFy
ThibaultFy approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@ThibaultFy ThibaultFy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !!

@guilhem-barthes guilhem-barthes merged commit e85047e into main Jun 7, 2023
@guilhem-barthes guilhem-barthes deleted the chore/remove-cli branch June 7, 2023 07:37
guilhem-barthes added a commit to Substra/substra-backend that referenced this pull request Jun 7, 2023
@guilhem-barthes
chore: remove references to substra commands (namely `substra login…
139579d 
…`) (#667)

## Related PR

- Substra/substra#362

## Description

Remove references to `substra` commands in documentation

## Notes

Fixes FL-489

## How has this been tested?

<!-- Please describe the tests that you ran to verify your changes.  -->

## Checklist

- [ ] [changelog](../CHANGELOG.md) was updated with notable changes
- [ ] documentation was updated

---------

Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThibaultFy ThibaultFy ThibaultFy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guilhem-barthes @ThibaultFy @Owlfred