-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Excellently improve player movements in Cyclops #2154
Excellently improve player movements in Cyclops #2154
Conversation
tornac1234
commented
Aug 3, 2024
•
edited
Loading
edited
- Excellently improve local player movements in cyclops
- Manage remote players movements in the cyclops with this new system
- Add modules collisions in the virtual cyclops
Ready for review 😀 |
Two things might need a fix but I'll need some review first:
|
Note for myself. I might want to have only one virtual cyclops spawned at a time, while the other ones are not activated as long as the player doesn't enter them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code only review. Love the 🚀 instant launch 🚀(didn't test cyclops yet)
Here's a patch file for handling the "task error handling" review comments:
https://gist.github.com/Measurity/fac122dcc55b5444d57ef85ca3324036
You can apply it directly from Rider
or Get-Clipboard | git apply
in Windows Terminal/PowerShell
NitroxClient/GameLogic/Spawning/Metadata/Processor/CyclopsMetadataProcessor.cs
Outdated
Show resolved
Hide resolved
NitroxPatcher/Patches/Dynamic/FPSCounter_UpdateDisplay_Patch.cs
Outdated
Show resolved
Hide resolved
295b409
to
8e512c5
Compare
One more commit to come (tomorrow) and I'll have fixed all issues that were listed after a testing session by @dartasen and @NinjaPedroX |
…er movements in cyclops
…longer push players, disconnect event is now fired
Co-authored-by: Measurity <measuring.infinity@gmail.com>
…player movement in cyclops broadcasting, fix cyclops name and color editor screen not appearing, fix entity reparenting not setting the transform parent accordingly
… without the bugs
350f333
to
c57adb1
Compare
c57adb1
to
1729d1b
Compare
… fix promity detection for both cyclops name/color editor and light panel
Needs one more commit to fix unheard steps sounds and cyclops motor being bugged. |
…r entering cyclops by seamoth docking
Implemented and adapted Tornac's "Instant Launch" profile from PR SubnauticaNitrox#2154 to the new launcher. Also fixed a thread error for when one is thrown while multiplayer is being launched, as well as changing errors thrown during server startup from being a notification to being an error dialog. Co-Authored-By: rootcan <24827220+tornac1234@users.noreply.github.com>
NitroxClient/Communication/Packets/Processors/PlayerMovementProcessor.cs
Show resolved
Hide resolved
NitroxPatcher/Patches/Dynamic/SubFire_EngineOverheatSimulation_Patch.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will create an issue about the movement rework as a follow up to comments (if the issue doesn't already exist)