Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvements #2163

Open
1 task
tornac1234 opened this issue Aug 13, 2024 · 0 comments
Open
1 task

Performance improvements #2163

tornac1234 opened this issue Aug 13, 2024 · 0 comments
Labels
Complexity: hard Requires deep understanding and/or hard to setup and verify
Milestone

Comments

@tornac1234
Copy link
Collaborator

tornac1234 commented Aug 13, 2024

Describe the issue

  • virtual colliders (VirtualCyclops.CreateColliderCopy) take some time to be built (they only need to be built once then they're cached): they use reflection and graph algorithms. It takes a total of ~10ms to build the 32 different constructables that can be built at the same time when starting a game with already those placed in a cyclops. To avoid performance impact during gameplay, the caching is done during initial sync (VirtualCyclops.InitializeConstructablesCache). Added in PR Excellently improve player movements in Cyclops #2154

"Maybe we deem it not necessary at release. Or if the release candidate runs bad, we can look at these performance issues."
Suggested by @Measurity

(NB: edit this description to add more things)

@tornac1234 tornac1234 added the Complexity: hard Requires deep understanding and/or hard to setup and verify label Aug 13, 2024
@Measurity Measurity added this to the Future milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: hard Requires deep understanding and/or hard to setup and verify
Projects
None yet
Development

No branches or pull requests

2 participants