Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Game finders overhaul #2121

Merged
merged 16 commits into from
Feb 29, 2024
Merged

Game finders overhaul #2121

merged 16 commits into from
Feb 29, 2024

Commits on Feb 25, 2024

  1. Modified namespace to be file-scoped by default in editorconfig

    @dartasen
    dartasen committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    6b8dd8a View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Reworked installation finders

    @dartasen
    dartasen committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    1401e17 View commit details
    Browse the repository at this point in the history

  2. Refactored GameFinders to use GameFinderResult 

    Instead of finders appending to an error list they now return an error result.
    @Measurity @dartasen
    Measurity authored and dartasen committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    b6312ca View commit details
    Browse the repository at this point in the history

  3. Added NotFound result to GameFinderResult type 

    NotFound should be returned when the game libraries were found but the requested game appears to not be installed.
    @Measurity @dartasen
    Measurity authored and dartasen committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    883ec88 View commit details
    Browse the repository at this point in the history

  4. Rename Steam file

    @dartasen
    dartasen committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    cdd5c87 View commit details
    Browse the repository at this point in the history

  5. Added GetUniqueNonCombinatoryFlags extension for Enums

    @Measurity
    Measurity committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    7d0d9ae View commit details
    Browse the repository at this point in the history

  6. Changed import sort order

    @dartasen
    dartasen committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    e18b489 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'installation-finders-v2' of github.com:dartasen/Nitrox … 

    …into installation-finders-v2
    @dartasen
    dartasen committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    438a555 View commit details
    Browse the repository at this point in the history

  8. Fix editorconfig pattern for csproj files 

    Spaces are part of the pattern match so it failed to apply the editorconfig.
    @Measurity
    Measurity committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    a6bf6d3 View commit details
    Browse the repository at this point in the history

  9. Added 0 value enum test for GetUniqueNonCombinatoryFlags

    @Measurity
    Measurity committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    b5d9402 View commit details
    Browse the repository at this point in the history

  10. Removed mix of double and single backslashes in SteamFinder.cs

    @Measurity
    Measurity committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    3eadb49 View commit details
    Browse the repository at this point in the history

  11. Moved GamePath getter success log to above if statement

    @Measurity
    Measurity committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    547f06e View commit details
    Browse the repository at this point in the history

  12. Added game folder structure validation to SteamFinder

    @Measurity
    Measurity committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    67b006e View commit details
    Browse the repository at this point in the history

  13. Removed an icon from launcher assets

    @Measurity
    Measurity committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    5dc30a1 View commit details
    Browse the repository at this point in the history

  14. GameInstallationFinder.cs "Subnautica" to generic "game" 

    Reasoning: any GameInfo game can be found via the finders, not just Subnautica

Co-authored-by: Jannify <23176718+Jannify@users.noreply.github.com>
    @Measurity @Jannify
    Measurity and Jannify authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    fe7916b View commit details
    Browse the repository at this point in the history

  15. Refactored SteamFinder.FindGame so both cases validate game structure 

    GameInstallationHelper.HasValidGameFolder was previously only checked when Steam game was installed on a different drive than Steam itself.
    @Measurity
    Measurity committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    7a34b7e View commit details
    Browse the repository at this point in the history