-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Game finders overhaul #2121
Merged
dartasen
merged 16 commits into
SubnauticaNitrox:master
from
dartasen:installation-finders-v2
Feb 29, 2024
Merged
Game finders overhaul #2121
dartasen
merged 16 commits into
SubnauticaNitrox:master
from
dartasen:installation-finders-v2
Feb 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Measurity
requested changes
Feb 27, 2024
dartasen
force-pushed
the
installation-finders-v2
branch
from
February 28, 2024 12:18
82ac22c
to
773bc82
Compare
Instead of finders appending to an error list they now return an error result.
NotFound should be returned when the game libraries were found but the requested game appears to not be installed.
dartasen
force-pushed
the
installation-finders-v2
branch
from
February 28, 2024 12:22
773bc82
to
cdd5c87
Compare
Measurity
force-pushed
the
installation-finders-v2
branch
from
February 28, 2024 15:09
f9e1e60
to
7bd816f
Compare
Measurity
approved these changes
Feb 28, 2024
Measurity
force-pushed
the
installation-finders-v2
branch
from
February 28, 2024 15:24
7bd816f
to
7d0d9ae
Compare
Measurity
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved again (I messed up a unit test)
…into installation-finders-v2
Jannify
requested changes
Feb 28, 2024
Spaces are part of the pattern match so it failed to apply the editorconfig.
Reasoning: any GameInfo game can be found via the finders, not just Subnautica Co-authored-by: Jannify <23176718+Jannify@users.noreply.github.com>
GameInstallationHelper.HasValidGameFolder was previously only checked when Steam game was installed on a different drive than Steam itself.
Jannify
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM CW
Coding-Hen
reviewed
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a spin-off of #2053, I splitted up this into several ones, so it will be easier to review. I applied the suggestions from the previous PR onto this one.
Nitrox has always defined an order in the way it searches the Subnautica installation files. This works in most cases, since users generally have only one installation of the game. However, this approach raises questions when a user has the game on both Steam & Epic.
The aim of this PR is to do away with this automatic way of doing things, by providing an API that lets you search for one or more installations of a given game (GameInfo) via flags (GameLibraries).
i.e:
That will allow the launcher to display all the path, and let the user choose between them. Rather than imposing it.
What's changed