Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid values #49

Closed
sandrojohanides opened this issue Nov 27, 2018 · 4 comments
Closed

Grid values #49

sandrojohanides opened this issue Nov 27, 2018 · 4 comments

Comments

@sandrojohanides
Copy link

There are various little bugs in grid values (keywords, numbers, etc.). The syntax sections of these can be used to create tests:

https://developer.mozilla.org/en-US/docs/Web/CSS/grid
https://developer.mozilla.org/en-US/docs/Web/CSS/grid-template-columns
https://developer.mozilla.org/en-US/docs/Web/CSS/grid-auto-columns

Let me know if you want me to point out the specifics.

@braver
Copy link
Member

braver commented Nov 27, 2018

Thanks! The MDN docs are super valuable, I think I'll manage with those links.

@braver
Copy link
Member

braver commented Dec 7, 2018

@sandrojohanides I pushed some fixes for grid syntax. Anything in particular that's still broken or missing for you?

@sandrojohanides
Copy link
Author

sandrojohanides commented Dec 7, 2018

Look beautiful, only bug I see is with the auto-fit and auto-fill keywords, which should be red.

screen shot 2018-12-07 at 17 57 17

From here: https://developer.mozilla.org/en-US/docs/Web/CSS/grid-template-columns

@braver
Copy link
Member

braver commented Dec 7, 2018

Just like in the CSS syntax, they're labelled as support.keyword.repetitions.css. I don't know why exactly. I value the consistency with the CSS, so if you want this changed better open an issue there.

I'm going to close this issue, if you find anything else, please report! Thanks so much for cooperating this last week! 🏅

@braver braver closed this as completed Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants