Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update CssBoxWidget to handle rtl marker boxes #1270

Merged
merged 4 commits into from
May 23, 2023

Conversation

Sub6Resources
Copy link
Owner

@Sub6Resources Sub6Resources commented May 16, 2023

This involved adding more options to the Margins class, as well as refactoring the padding option to take a new HtmlPaddings object.

Fixes #1257

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage: 73.68% and project coverage change: +4.09 🎉

Comparison is base (496d1aa) 60.02% compared to head (103ce62) 64.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1270      +/-   ##
==========================================
+ Coverage   60.02%   64.11%   +4.09%     
==========================================
  Files          37       38       +1     
  Lines        2699     2979     +280     
==========================================
+ Hits         1620     1910     +290     
+ Misses       1079     1069      -10     
Impacted Files Coverage Δ
lib/src/style/padding.dart 51.02% <51.02%> (ø)
lib/src/style/margin.dart 64.00% <61.44%> (-19.79%) ⬇️
lib/src/style.dart 85.64% <76.92%> (+0.84%) ⬆️
lib/src/css_parser.dart 35.92% <89.92%> (+18.44%) ⬆️
lib/src/css_box_widget.dart 64.95% <91.30%> (+0.61%) ⬆️
lib/src/processing/margins.dart 93.87% <92.85%> (+0.85%) ⬆️
lib/src/builtins/styled_element_builtin.dart 92.42% <100.00%> (+0.20%) ⬆️
lib/src/style/length.dart 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

… Update CssBoxWidget to handle rtl marker boxes
@Sub6Resources Sub6Resources added this to the 3.0.0 milestone May 18, 2023
@Sub6Resources Sub6Resources self-assigned this May 18, 2023
@Sub6Resources Sub6Resources added the bugfix Fixes a bug in the package label May 18, 2023
@Sub6Resources Sub6Resources merged commit d709199 into master May 23, 2023
3 checks passed
@Sub6Resources Sub6Resources deleted the fix/rtl-list-markers branch May 23, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a bug in the package
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] UL list dots rendered on the left for rtl text
1 participant