-
-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Version 3.0.0-alpha.6 #1149
Conversation
- flutter_html@3.0.0-alpha.6 - flutter_html_audio@3.0.0-alpha.4 - flutter_html_iframe@3.0.0-alpha.4 - flutter_html_table@3.0.0-alpha.4 - flutter_html_math@3.0.0-alpha.4 - flutter_html_video@3.0.0-alpha.5 - flutter_html_all@3.0.0-alpha.6 - flutter_html_svg@3.0.0-alpha.4
Codecov ReportBase: 49.70% // Head: 49.70% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #1149 +/- ##
=======================================
Coverage 49.70% 49.70%
=======================================
Files 18 18
Lines 2682 2682
=======================================
Hits 1333 1333
Misses 1349 1349 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, with one minor remark.
@@ -11,7 +11,7 @@ dependencies: | |||
flutter: | |||
sdk: flutter | |||
html: '>=0.15.0 <1.0.0' | |||
flutter_html: '>=3.0.0-alpha.3 <4.0.0' | |||
flutter_html: ^3.0.0-alpha.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whilst not a big problem at all, as they are dependencies on our own libs, this does make it slightly less free for our users to, for example, use a flutter_html
(core) 3.1.0 with flutter_html_video 3.0. Therefor, when we publish minor releases such as 3.1.0 we need to also release updates to our sub-libraries. Again, not a big problem at all but if melos supports it we might want to keep the less restrictive <4.0.0
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point. Unfortunately, I'm not sure that melos supports that, and I could see how that is a little more complex to implement on their end.
I'll look a little deeper into that though and open a ticket with melos if there isn't one already, to see if that's something they're considering.
Just ran a
melos version
and updated the primary changelog. After this is approved and merged, I'll publish the new package versions.